You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/02/20 19:51:28 UTC
[GitHub] [qpid-dispatch] jiridanek opened a new pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c
jiridanek opened a new pull request #1049:
URL: https://github.com/apache/qpid-dispatch/pull/1049
As explained on the Jira, suppressing all leaks from unittests is kind of silly, because it can hide leaks in production code which would be otherwise easy to diagnose, if unittests could reveal them. The leak here is only in test code and it is easy to fix.
```
9: Test Case thread_tests.test_condition: PASS
9:
9: =================================================================
9: ==19457==ERROR: LeakSanitizer: detected memory leaks
9:
9: Direct leak of 1160 byte(s) in 1 object(s) allocated from:
9: #0 0x7fe6d5751e8f in __interceptor_malloc (/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xace8f)
9: #1 0x40d9fe in qd_malloc ../include/qpid/dispatch/ctools.h:229
9: #2 0x40d9fe in test_core_timer ../tests/core_timer_test.c:37
9: #3 0x40e4b2 in core_timer_tests ../tests/core_timer_test.c:183
9: #4 0x406c83 in main ../tests/run_unit_tests.c:69
9: #5 0x7fe6d3ccbcbc in __libc_start_main (/nix/store/q53f5birhik4dxg3q3r2g5f324n7r5mc-glibc-2.31-74/lib/libc.so.6+0x23cbc)
9:
9: -----------------------------------------------------
9: Suppressions used:
9: count bytes template
9: 1 56 qdr_core_subscribe
9: 572 916269 ^_PyMem_DebugRawAlloc$
9: 5 3296 ^_PyMem_DebugRawRealloc$
9: -----------------------------------------------------
9:
9: SUMMARY: AddressSanitizer: 1160 byte(s) leaked in 1 allocation(s).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek merged pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #1049:
URL: https://github.com/apache/qpid-dispatch/pull/1049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io commented on pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1049:
URL: https://github.com/apache/qpid-dispatch/pull/1049#issuecomment-782744008
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=h1) Report
> Merging [#1049](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=desc) (933aba6) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/844f995a580ca630afe951ea7c5071bb02bc33f6?el=desc) (844f995) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 82.48% 82.47% -0.01%
==========================================
Files 111 111
Lines 27425 27426 +1
==========================================
- Hits 22621 22620 -1
- Misses 4804 4806 +2
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [tests/core\_timer\_test.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-dGVzdHMvY29yZV90aW1lcl90ZXN0LmM=) | `90.47% <100.00%> (+0.09%)` | :arrow_up: |
| [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0.00%> (-4.15%)` | :arrow_down: |
| [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `84.15% <0.00%> (-1.00%)` | :arrow_down: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `91.81% <0.00%> (-0.44%)` | :arrow_down: |
| [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `93.12% <0.00%> (-0.39%)` | :arrow_down: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.03% <0.00%> (ø)` | |
| [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3NlcnZlci5j) | `86.78% <0.00%> (+0.10%)` | :arrow_up: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `87.06% <0.00%> (+0.21%)` | :arrow_up: |
| [src/adaptors/http1/http1\_server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL2FkYXB0b3JzL2h0dHAxL2h0dHAxX3NlcnZlci5j) | `84.79% <0.00%> (+0.29%)` | :arrow_up: |
| [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `93.04% <0.00%> (+0.39%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/qpid-dispatch/pull/1049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=footer). Last update [844f995...933aba6](https://codecov.io/gh/apache/qpid-dispatch/pull/1049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] jiridanek commented on pull request #1049: DISPATCH-1962 Fix qdr_core_t leak in run_unit_tests.c
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #1049:
URL: https://github.com/apache/qpid-dispatch/pull/1049#issuecomment-803294379
Ready for review. Just a missing free() at the end of a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org