You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/18 16:03:28 UTC
[GitHub] [druid] isandeep41 opened a new pull request #11462: fixes possible data truncation
isandeep41 opened a new pull request #11462:
URL: https://github.com/apache/druid/pull/11462
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
Fixes #11461
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [x] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [x] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450656
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
@isandeep41 Cool, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-884363407
@suneet-s @asdf2014 I have added a unit test to catch the possible data truncation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-882731590
This pull request **fixes 1 alert** when merging b0554b6e36bae3f05569966690475233db78cfbf into 8729b4089319a0bbb4e5c0b9a59c8cfa15dc0bd7 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-0ff41f0dd920ee490eee826f258363654cdb16df)
**fixed alerts:**
* 1 for User\-controlled data in numeric cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-884686815
@suneet-s I have updated the PR description, let me know if this looks good to you now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450656
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
@isandeep41 Cool, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450301
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
thanks for pointing, have removed unnecessary variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450656
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
@isandeep41 Cool, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-882731590
This pull request **fixes 1 alert** when merging b0554b6e36bae3f05569966690475233db78cfbf into 8729b4089319a0bbb4e5c0b9a59c8cfa15dc0bd7 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-0ff41f0dd920ee490eee826f258363654cdb16df)
**fixed alerts:**
* 1 for User\-controlled data in numeric cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r671952095
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
This `param2` variable seems unnecessary, you can directly use `return eval((long) param)` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883045417
@isandeep41 I see you marked integration tests have been added for this PR, but I don't see any in the delta. Have you been able to reproduce this scenario locally? What would it take to make this a test that shows the problem before your fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 merged pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
asdf2014 merged pull request #11462:
URL: https://github.com/apache/druid/pull/11462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883045417
@isandeep41 I see you marked integration tests have been added for this PR, but I don't see any in the delta. Have you been able to reproduce this scenario locally? What would it take to make this a test that shows the problem before your fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450301
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
thanks for pointing, have removed unnecessary variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883530313
@suneet-s it seems the `eval` methods, under `UnivariateMathFunction` class, are dummy one. All sub classes are overriding the `eval` methods, so no actual call will be ever made.
This pr might only fix the lgtm alert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 commented on a change in pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 commented on a change in pull request #11462:
URL: https://github.com/apache/druid/pull/11462#discussion_r672450301
##########
File path: core/src/main/java/org/apache/druid/math/expr/Function.java
##########
@@ -218,7 +218,13 @@ protected ExprEval eval(long param)
protected ExprEval eval(double param)
{
- return eval((long) param);
+ long param2;
+ if (param > Long.MIN_VALUE && param < Long.MAX_VALUE) {
+ param2 = (long) param;
Review comment:
thanks for pointing, have removed unnecessary variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 removed a comment on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 removed a comment on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883530313
@suneet-s I find that the below test case does call the `eval` function
```java
assertExpr("bitwiseConvertLongBitsToDouble(bitwiseConvertLongBitsToDouble(4611686018427387904))", 1.0E-323);
```
In this test case eval method only receives `2.0` value.
I will update if I can reproduce the method call with value greater than Long.MAX_VALUE or less than Long.MIN_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-882731590
This pull request **fixes 1 alert** when merging b0554b6e36bae3f05569966690475233db78cfbf into 8729b4089319a0bbb4e5c0b9a59c8cfa15dc0bd7 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-0ff41f0dd920ee490eee826f258363654cdb16df)
**fixed alerts:**
* 1 for User\-controlled data in numeric cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-882089414
This pull request **fixes 1 alert** when merging aabed1c5735f4ce07b8ac157afe768bf4b1de4e7 into 8729b4089319a0bbb4e5c0b9a59c8cfa15dc0bd7 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-284c5596f99a52429f338f23b2db89b7f4f852e0)
**fixed alerts:**
* 1 for User\-controlled data in numeric cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883045417
@isandeep41 I see you marked integration tests have been added for this PR, but I don't see any in the delta. Have you been able to reproduce this scenario locally? What would it take to make this a test that shows the problem before your fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-884413898
This pull request **fixes 1 alert** when merging 7dd5fafc3c31d92cae7e51cfa2c7029ec9c76fe5 into 167c45260c76057b9856bd073661365663bd80f2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-b959c3e95a4da27c44b8bfe2b710b9e774d992b0)
**fixed alerts:**
* 1 for User\-controlled data in numeric cast
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] isandeep41 edited a comment on pull request #11462: fixes possible data truncation
Posted by GitBox <gi...@apache.org>.
isandeep41 edited a comment on pull request #11462:
URL: https://github.com/apache/druid/pull/11462#issuecomment-883530313
@suneet-s I find that the below test case does call the `eval` function
```java
assertExpr("bitwiseConvertLongBitsToDouble(bitwiseConvertLongBitsToDouble(4611686018427387904))", 1.0E-323);
```
In this test case eval method only receives `2.0` value.
I will update if I can reproduce the method call with value greater than Long.MAX_VALUE or less than Long.MIN_VALUE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org