You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Sai Hemanth Gantasala (Jira)" <ji...@apache.org> on 2023/01/26 01:00:21 UTC
[jira] [Commented] (HIVE-26793) Create a new configuration to override "no compaction" for tables
[ https://issues.apache.org/jira/browse/HIVE-26793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680848#comment-17680848 ]
Sai Hemanth Gantasala commented on HIVE-26793:
----------------------------------------------
This patch will cause build failures locally when compiled with thrift because this change [https://github.com/apache/hive/pull/3822/files#diff-944faa284e92a1090cd79c781b54acf30fb2ab29f78cf952576036f452577cf4R66]
The hive_metastoreConstants.java is generated file based on constants declared in hive_metastore.thrift class. Please make the desired change ([https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L3184]) in hive_metastore.thrift and then compile hive using thrift which would then generate the required change in hive_metastoreConstants.java class.
[~kokila19] Can you please raise an addendum patch with the above-suggested changes?
> Create a new configuration to override "no compaction" for tables
> -----------------------------------------------------------------
>
> Key: HIVE-26793
> URL: https://issues.apache.org/jira/browse/HIVE-26793
> Project: Hive
> Issue Type: Improvement
> Reporter: Kokila N
> Assignee: Kokila N
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Currently a simple user can create a table with {color:#6a8759}no_auto_compaction=true{color} table property and create an aborted write transaction writing to this table. This way a malicious user can prevent cleaning up data for the aborted transaction, creating performance degradation.
> This configuration should be allowed to overridden on a database level: adding {color:#6a8759}no_auto_compaction=false{color} should override the table level setting forcing the initiator to schedule compaction for all tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)