You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org> on 2005/05/13 17:25:25 UTC
[jira] Created: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
controls-webservices-blank sample needs some fixes for consistency
------------------------------------------------------------------
Key: BEEHIVE-719
URL: http://issues.apache.org/jira/browse/BEEHIVE-719
Project: Beehive
Type: Bug
Components: Samples
Versions: V1
Reporter: Eddie O'Neil
Fix For: V1
In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
- instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
- need to document the dependence on junit.jar in a README.txt.
- repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
- remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "daryoush mehrtash (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=all ]
daryoush mehrtash closed BEEHIVE-719:
-------------------------------------
Resolution: Fixed
bug is fixed with rev: 170408
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: daryoush mehrtash
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "daryoush mehrtash (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=comments#action_65473 ]
daryoush mehrtash commented on BEEHIVE-719:
-------------------------------------------
Eddie,
I had updated the comments on this before re-assigning it to you, but it was lost somehow. This was my comments before I reassigned this bug to you for re-evaluation:
- instead of using the "get.dependencies" call,...
get.dependencies is only used in the build.xml (that is part of the distribution). I looked at the deploy macros; they seem to depend on the WEB-INF structure for the project. There is not WEB-INF directory in the controls-webservices-blank. I did make a change to the target name to deploy-beehive to be more consistent.
- need to document the dependence on junit.jar in a README.txt
Done.
- repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
I am not sure what code you are thinking about. There is no soruce code in the controls-webservices-blank (other the test case). So I am not sure what you want to be moved to the above package. There is source code that is generated, i have choosen "mypackage" as the package name, since the user would choose the package name that is appropriate to his/her project.
- remove the systemcontrols-imports.xml file which is part of the sample and was copied from
Done.
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: Eddie O'Neil
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "daryoush mehrtash (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=all ]
daryoush mehrtash reassigned BEEHIVE-719:
-----------------------------------------
Assign To: daryoush mehrtash (was: daryoush mehrtash)
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: daryoush mehrtash
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "daryoush mehrtash (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=all ]
daryoush mehrtash reassigned BEEHIVE-719:
-----------------------------------------
Assign To: Eddie O'Neil (was: daryoush mehrtash)
Please either update this bug and reassign it to me, or close it.
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: Eddie O'Neil
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=all ]
Eddie O'Neil reassigned BEEHIVE-719:
------------------------------------
Assign To: daryoush mehrtash
Daryoush, since you wrote this sample, any chance you'll be able to take care of these changes?
Thanks!
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: daryoush mehrtash
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-719) controls-webservices-blank sample needs some fixes for consistency
Posted by "Eddie O'Neil (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-719?page=all ]
Eddie O'Neil updated BEEHIVE-719:
---------------------------------
Assign To: daryoush mehrtash (was: Eddie O'Neil)
Yeah; you make some good points. A couple of things:
- I agree that we can't use <deploy-wsm>, which is unfortunate. But, would you mind replacing this:
<fileset file="${beehive.home}/lib/controls/beehive-controls.jar" />
with <deploy-controls>?
- can you rename the readme.txt file to README.txt so it's consistent with the rest of the READMEs we use?
- in the readme, it would probably be good to reference the tutorial Steve wrote for this the other day. In general, samples in the distribution shouldn't be documented on the wiki as that doesn't version with the code in the tree.
- in the readme, can you detail the instructions needed to setup JUnit? In this case, I think it needs to be in $ANT_HOME/lib, but we should explain what it takes to get the sample running.
Thanks!
> controls-webservices-blank sample needs some fixes for consistency
> ------------------------------------------------------------------
>
> Key: BEEHIVE-719
> URL: http://issues.apache.org/jira/browse/BEEHIVE-719
> Project: Beehive
> Type: Bug
> Components: Samples
> Versions: V1
> Reporter: Eddie O'Neil
> Assignee: daryoush mehrtash
> Fix For: V1
>
> In looking over the controls-webservices-blank tutorial checked in last night, there are a few things we could do to make it more consistent with the wsm-* and controls-* tutorials.
> - instead of using the "get.dependencies" call, the build.xml and build-svn.xml files should use the Beehive provided macros for <deploy-wsm> and <deploy-controls> the individual control JARs (like web services) should be copied explicitly using Ant's <copy>
> - need to document the dependence on junit.jar in a README.txt.
> - repackage the samples into an "org.apache.beehive.samples.controls.webservice" directory
> - remove the systemcontrols-imports.xml file which is part of the sample and was copied from beehive/trunk/system-controls into the sample. It doesn't seem to be used by the sample.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira