[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38270: [SPARK-40538] [CONNECT] Improve built-in function support for Python client.

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #38270:
URL: https://github.com/apache/spark/pull/38270#discussion_r996448216


##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -19,9 +19,12 @@
 import unittest
 import tempfile
 
+import pandas

Review Comment:
   Hm .. we gonna fix this or do something. pandas isn't a required library for SQL package. Should probably skip this tests when pandas is not installed for now until we have a clear way to handle this. (see `pyspark.testing.sqlutils.have_pandas` and `pyspark.sql.tests.test_arrow_map`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org