You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pivot.apache.org by gb...@apache.org on 2010/11/30 13:57:23 UTC
svn commit: r1040497 - in /pivot/trunk/core/src/org/apache/pivot/collections:
adapter/ListAdapter.java concurrent/SynchronizedList.java
Author: gbrown
Date: Tue Nov 30 12:57:23 2010
New Revision: 1040497
URL: http://svn.apache.org/viewvc?rev=1040497&view=rev
Log:
Remove IllegalArgumentException from ListAdapter#remove(T) and SynchronizedList#remove(T).
Modified:
pivot/trunk/core/src/org/apache/pivot/collections/adapter/ListAdapter.java
pivot/trunk/core/src/org/apache/pivot/collections/concurrent/SynchronizedList.java
Modified: pivot/trunk/core/src/org/apache/pivot/collections/adapter/ListAdapter.java
URL: http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/adapter/ListAdapter.java?rev=1040497&r1=1040496&r2=1040497&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/adapter/ListAdapter.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/adapter/ListAdapter.java Tue Nov 30 12:57:23 2010
@@ -159,12 +159,10 @@ public class ListAdapter<T> implements L
@Override
public int remove(T item) {
int index = indexOf(item);
- if (index == -1) {
- throw new IllegalArgumentException();
+ if (index != -1) {
+ remove(index, 1);
}
- remove(index, 1);
-
return index;
}
Modified: pivot/trunk/core/src/org/apache/pivot/collections/concurrent/SynchronizedList.java
URL: http://svn.apache.org/viewvc/pivot/trunk/core/src/org/apache/pivot/collections/concurrent/SynchronizedList.java?rev=1040497&r1=1040496&r2=1040497&view=diff
==============================================================================
--- pivot/trunk/core/src/org/apache/pivot/collections/concurrent/SynchronizedList.java (original)
+++ pivot/trunk/core/src/org/apache/pivot/collections/concurrent/SynchronizedList.java Tue Nov 30 12:57:23 2010
@@ -105,12 +105,10 @@ public class SynchronizedList<T> impleme
@Override
public synchronized int remove (T item) {
int index = indexOf(item);
- if (index == -1) {
- throw new IllegalArgumentException("item not in list");
+ if (index != -1) {
+ remove(index, 1);
}
- remove(index, 1);
-
return index;
}