You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/04/05 05:56:51 UTC

Review Request 66470: Migration: Unit Tests Refactoring

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66470/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2460
    https://issues.apache.org/jira/browse/ATLAS-2460


Repository: atlas


Description
-------

**Approach**
- Added common code to base class.
- Converted tests from IT to unit tests.


Diffs
-----

  repository/src/test/java/org/apache/atlas/repository/migration/HiveParititionIT.java bd1fb4cc 
  repository/src/test/java/org/apache/atlas/repository/migration/HiveStocksIT.java 7fc8f2ae 
  repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java ed2793f2 
  repository/src/test/resources/stocks_db/atlas-migration-data.json PRE-CREATION 
  repository/src/test/resources/stocks_db/atlas-migration-typesdef.json PRE-CREATION 


Diff: https://reviews.apache.org/r/66470/diff/1/


Testing
-------

**Verification**
Build with tests enabled.


Thanks,

Ashutosh Mestry

Re: Review Request 66470: Migration: Unit Tests Refactoring

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66470/#review200536
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On April 5, 2018, 5:56 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66470/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 5:56 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2460
>     https://issues.apache.org/jira/browse/ATLAS-2460
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Approach**
> - Added common code to base class.
> - Converted tests from IT to unit tests.
> 
> 
> Diffs
> -----
> 
>   repository/src/test/java/org/apache/atlas/repository/migration/HiveParititionIT.java bd1fb4cc 
>   repository/src/test/java/org/apache/atlas/repository/migration/HiveStocksIT.java 7fc8f2ae 
>   repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java ed2793f2 
>   repository/src/test/resources/stocks_db/atlas-migration-data.json PRE-CREATION 
>   repository/src/test/resources/stocks_db/atlas-migration-typesdef.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66470/diff/1/
> 
> 
> Testing
> -------
> 
> **Verification**
> Build with tests enabled.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>