You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/30 08:10:30 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11472: Add metrics [total_write_entries_size, total_write_enties_logical_size, total_read_entries_size ] for topic/namespace
Anonymitaet commented on a change in pull request #11472:
URL: https://github.com/apache/pulsar/pull/11472#discussion_r679734607
##########
File path: site2/docs/reference-metrics.md
##########
@@ -150,6 +150,9 @@ All the namespace metrics are labelled with the following labels:
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this namespace (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this namespace (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
+| pulsar_total_write_entries_logical_size | Gauge | The total write entries size (without accounting for replicas). |
Review comment:
```suggestion
| pulsar_total_write_entries_logical_size | Gauge | The total size of write entries without replicas (in bytes). |
```
##########
File path: site2/docs/reference-metrics.md
##########
@@ -150,6 +150,9 @@ All the namespace metrics are labelled with the following labels:
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this namespace (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this namespace (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
+| pulsar_total_write_entries_logical_size | Gauge | The total write entries size (without accounting for replicas). |
+| pulsar_total_read_entries_size | Gauge | The total read entries size. |
Review comment:
```suggestion
| pulsar_total_read_entries_size | Gauge | The total size of read entries (in bytes). |
```
##########
File path: site2/docs/reference-metrics.md
##########
@@ -191,12 +194,16 @@ All the topic metrics are labelled with the following labels:
| pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (bytes/second). |
| pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (bytes/second). |
| pulsar_storage_size | Gauge | The total storage size of the topics in this topic owned by this broker (bytes). |
+| pulsar_storage_logical_size | Gauge | The storage size (without accounting for replicas) of the topics in this namespace owned by this broker (bytes). |
| pulsar_storage_backlog_size | Gauge | The total backlog size of the topics of this topic owned by this broker (messages). |
| pulsar_storage_offloaded_size | Gauge | The total amount of the data in this topic offloaded to the tiered storage (bytes). |
| pulsar_storage_backlog_quota_limit | Gauge | The total amount of the data in this topic that limit the backlog quota (bytes). |
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this topic (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this topic (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
Review comment:
```suggestion
| pulsar_total_write_entries_size | Gauge | The total size of write entries (in bytes). |
```
##########
File path: site2/docs/reference-metrics.md
##########
@@ -191,12 +194,16 @@ All the topic metrics are labelled with the following labels:
| pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (bytes/second). |
| pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (bytes/second). |
| pulsar_storage_size | Gauge | The total storage size of the topics in this topic owned by this broker (bytes). |
+| pulsar_storage_logical_size | Gauge | The storage size (without accounting for replicas) of the topics in this namespace owned by this broker (bytes). |
| pulsar_storage_backlog_size | Gauge | The total backlog size of the topics of this topic owned by this broker (messages). |
| pulsar_storage_offloaded_size | Gauge | The total amount of the data in this topic offloaded to the tiered storage (bytes). |
| pulsar_storage_backlog_quota_limit | Gauge | The total amount of the data in this topic that limit the backlog quota (bytes). |
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this topic (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this topic (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
+| pulsar_total_write_entries_logical_size | Gauge | The total write entries size (without accounting for replicas). |
+| pulsar_total_read_entries_size | Gauge | The total read entries size. |
Review comment:
same
##########
File path: site2/docs/reference-metrics.md
##########
@@ -191,12 +194,16 @@ All the topic metrics are labelled with the following labels:
| pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (bytes/second). |
| pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (bytes/second). |
| pulsar_storage_size | Gauge | The total storage size of the topics in this topic owned by this broker (bytes). |
+| pulsar_storage_logical_size | Gauge | The storage size (without accounting for replicas) of the topics in this namespace owned by this broker (bytes). |
Review comment:
```suggestion
| pulsar_storage_logical_size | Gauge | The storage size of topics in the namespace owned by the broker without replicas (in bytes). |
```
##########
File path: site2/docs/reference-metrics.md
##########
@@ -150,6 +150,9 @@ All the namespace metrics are labelled with the following labels:
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this namespace (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this namespace (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
Review comment:
Do you mean this? Correct me if I'm wrong.
##########
File path: site2/docs/reference-metrics.md
##########
@@ -150,6 +150,9 @@ All the namespace metrics are labelled with the following labels:
| pulsar_storage_write_rate | Gauge | The total message batches (entries) written to the storage for this namespace (message batches / second). |
| pulsar_storage_read_rate | Gauge | The total message batches (entries) read from the storage for this namespace (message batches / second). |
| pulsar_subscription_delayed | Gauge | The total message batches (entries) are delayed for dispatching. |
+| pulsar_total_write_entries_size | Gauge | The total write entries size . |
Review comment:
```suggestion
| pulsar_total_write_entries_size | Gauge | The total size of write entries (in bytes). |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org