You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "lriggs (via GitHub)" <gi...@apache.org> on 2026/01/30 20:04:11 UTC

[PR] GH-49087 [CI][Packaging][Gandiva] Some of our Linux packaging jobs fa… [arrow]

lriggs opened a new pull request, #49091:
URL: https://github.com/apache/arrow/pull/49091

   …il compiling Gandiva
   
   
   ### Rationale for this change
   Fixes CI packaging error.
   
   ### What changes are included in this PR?
   Adjust code to handle different LLVM versions.
   
   ### Are these changes tested?
   Yes, compiling.
   
   ### Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49087 [CI][Packaging][Gandiva] Add support for LLVM 15 or earlier again [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.

kou commented on code in PR #49091:
URL: https://github.com/apache/arrow/pull/49091#discussion_r2749246877


##########
cpp/src/gandiva/engine.cc:
##########
@@ -230,7 +230,11 @@ Result<std::unique_ptr<llvm::orc::LLJIT>> BuildJIT(
 #endif
 
   jit_builder.setJITTargetMachineBuilder(std::move(jtmb));
+#if LLVM_VERSION_MAJOR >= 16
   jit_builder.setDataLayout(std::make_optional(data_layout));
+#else
+  jit_builder.setDataLayout(llvm::Optional<llvm::DataLayout>(data_layout));
+#endif

Review Comment:
   This may work:
   
   ```suggestion
     jit_builder.setDataLayout(data_layout);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49087 [CI][Packaging][Gandiva] Some of our Linux packaging jobs fa… [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #49091:
URL: https://github.com/apache/arrow/pull/49091#issuecomment-3825502653

   :warning: GitHub issue #49087 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49087 [CI][Packaging][Gandiva] Add support for LLVM 15 or earlier again [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #49091:
URL: https://github.com/apache/arrow/pull/49091#issuecomment-3827976644

   :warning: GitHub issue #49087 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49087 [CI][Packaging][Gandiva] Add support for LLVM 15 or earlier again [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #49091:
URL: https://github.com/apache/arrow/pull/49091#issuecomment-3827974127

   :warning: GitHub issue #49087 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-49087 [CI][Packaging][Gandiva] Add support for LLVM 15 or earlier again [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.

kou merged PR #49091:
URL: https://github.com/apache/arrow/pull/49091


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org