You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/23 19:33:46 UTC

[GitHub] [skywalking] Debanjan05 opened a new issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Debanjan05 opened a new issue #6607:
URL: https://github.com/apache/skywalking/issues/6607


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Bug
   
   ___
   ### Bug
   - Which version of SkyWalking, OS, and JRE?
   
   Skywalking 8.2
   skywalking-client-js - v0.4.0
   OS - Mac
   Angular app version - 11
   
   - What happened?
   I'm trying to test an angular app with the agent - I'm able to register the app and get performance data and app load. But browser error logs which I'm generating in the app are not captured by the agent and hence not pushed to the collector.
   I'm able to connect and send browser error logs for Vue and React apps with the same agent. 
   
   This is what I'm doing to register and send the data in main.ts file of the angular app - 
   
   _ClientMonitor.register({
     collector:
       'http://localhost:12800',
     service: 'angular-test',
     pagePath: location.href,
     serviceVersion: 'v1.0.0',
     jsErrors: true,
     apiErrors: true,
     resourceErrors: true,
     enableSPA: true,
     useFmp: true,
     autoTracePerf: true,
     detailMode: true,
   });_ 
   
   I don't see any network calls happening to collector endpoint when any error is triggered from the angular application.
   Presently for testing purpose I'm just throwing an error on some button click - _throw new EvalError("EvalError");_
   
   Please let me know if this is a bug or I'm missing something on the configuration part.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Fine0830 commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-805399452


   @Debanjan05 Here is a Angular demo with skywalking-client-js. https://github.com/Fine0830/angular-demo/blob/master/src/app/home/home.component.ts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Fine0830 commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-813980044


   Yes, it does. I sorted out the interceptors of the framework, including React, Angular, Vue. 
   Here's how to use error handler in projects,
   <img width="578" alt="1" src="https://user-images.githubusercontent.com/20871783/113690070-9bd12780-96fd-11eb-9250-09a32a6505b7.png">
   
   From my point, No matter which framework, we just implement `logErrorToSWClientJs` in skywalking-client-js.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-843037011


   We need a 0.5.1, `0.5.0` faces an issue in the release process. 0.5.1 is on the way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-836253320


   > Hi @Fine0830 What is the logErrorToSWClientJS(error) implementation? Where have you implememented this?
   
   We haven't released that version yet. It is on the main branch or next 0.5.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] bee-cult commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
bee-cult commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-843033942


   Any update on 0.5.0 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Debanjan05 commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Debanjan05 commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-836853196


   Thanks @wu-sheng. Any tentative time or date for the release of 0.5.0 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-843055775


   Learn to subscribe to the mail list. Official release happens there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] bee-cult commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
bee-cult commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-843055105


   Any timeline of 0.5.1 ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Fine0830 edited a comment on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-813980044


   Yes, it does. I sorted out the interceptors of the framework, including React, Angular, Vue. 
   Here's how to use error handler in projects,
   <img width="660" alt="1" src="https://user-images.githubusercontent.com/20871783/113691247-cf608180-96fe-11eb-8ff9-6515d9553c07.png">
   
   From my point, No matter which framework, we just implement `logErrorToSWClientJs` in skywalking-client-js.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-837491236


   > Thanks @wu-sheng. Any tentative timeline or date for the release of 0.5.0 release?
   
   Should be soon. @Fine0830 @Jtrust any update?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Debanjan05 commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Debanjan05 commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-836240749


   Hi @Fine0830 What is the logErrorToSWClientJS(error) implementation? Where have you implememented this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6607:
URL: https://github.com/apache/skywalking/issues/6607


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Debanjan05 edited a comment on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Debanjan05 edited a comment on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-836853196


   Thanks @wu-sheng. Any tentative timeline or date for the release of 0.5.0 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] Fine0830 commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-808619748


   For https://the-asf.slack.com/archives/CHQ1L4T54/p1616746142035800?thread_ts=1614298078.005500&cid=CHQ1L4T54,  I plan to implement a manual report function to handle frames `errorHandler`. Meanwhile the issue will be solved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6607: Browser error logs not captured by skywalking-client-js agent for Angular apps

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6607:
URL: https://github.com/apache/skywalking/issues/6607#issuecomment-808623320


   > For https://the-asf.slack.com/archives/CHQ1L4T54/p1616746142035800?thread_ts=1614298078.005500&cid=CHQ1L4T54, I plan to implement a manual report function to handle frames `errorHandler`. Meanwhile the issue will be solved.
   
   Doesn't `error` handler of Angular have a unified place to intercept?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org