You are viewing a plain text version of this content. The canonical link for it is here.
Posted to xmlrpc-auto@ws.apache.org by jo...@apache.org on 2007/08/01 22:55:20 UTC

svn commit: r561948 - in /webservices/xmlrpc/trunk: pom.xml server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java src/changes/changes.xml

Author: jochen
Date: Wed Aug  1 13:55:13 2007
New Revision: 561948

URL: http://svn.apache.org/viewvc?view=rev&rev=561948
Log:
Address matching in the Webserver wasn't actually working,
because casting of integers to bytes was implemented wrong.
PR: XMLRPC-145
Submitted-by: Gamaliel Amaudruz, gamaliel@fastmail.fm

Modified:
    webservices/xmlrpc/trunk/pom.xml
    webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
    webservices/xmlrpc/trunk/src/changes/changes.xml

Modified: webservices/xmlrpc/trunk/pom.xml
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/pom.xml?view=diff&rev=561948&r1=561947&r2=561948
==============================================================================
--- webservices/xmlrpc/trunk/pom.xml (original)
+++ webservices/xmlrpc/trunk/pom.xml Wed Aug  1 13:55:13 2007
@@ -120,6 +120,10 @@
     </developers>
     <contributors>
         <contributor>
+            <name>Gamaliel Amaudruz</name>
+            <email>gamaliel@fastmail.fm</email>
+        </contributor>
+        <contributor>
             <name>Alan Burlison</name>
             <email>Alan.Burlison@sun.com</email>
         </contributor>

Modified: webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java?view=diff&rev=561948&r1=561947&r2=561948
==============================================================================
--- webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java (original)
+++ webservices/xmlrpc/trunk/server/src/main/java/org/apache/xmlrpc/webserver/WebServer.java Wed Aug  1 13:55:13 2007
@@ -86,7 +86,10 @@
 					if ("*".equals(next)) {
 						pattern[i] = 256;
 					} else {
-						pattern[i] = Integer.parseInt(next);
+					    /* Note: *Not* pattern[i] = Integer.parseInt(next);
+					     * See XMLRPC-145
+					     */
+						pattern[i] = (byte) Integer.parseInt(next);
 					}
 				}
 			} catch (Exception e) {

Modified: webservices/xmlrpc/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/webservices/xmlrpc/trunk/src/changes/changes.xml?view=diff&rev=561948&r1=561947&r2=561948
==============================================================================
--- webservices/xmlrpc/trunk/src/changes/changes.xml (original)
+++ webservices/xmlrpc/trunk/src/changes/changes.xml Wed Aug  1 13:55:13 2007
@@ -69,6 +69,11 @@
         The redirect handling (XMLRPC-132) wasn't actually working,
         because it treated an URI as a charset name.
       </action>
+      <action dev="jochen" type="fix" issue="XMLRPC-145"
+          due-to="Gamaliel Amaudruz" due-to-email="gamaliel@fastmail.fm">
+        Address matching in the Webserver wasn't actually working,
+        because casting of integers to bytes was implemented wrong.
+      </action>
     </release>
     <release version="3.0.1-SNAPSHOT" date="Not yet released">
       <action dev="jochen" type="fix">