You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Aaron Evans (JIRA)" <je...@portals.apache.org> on 2008/09/17 16:27:45 UTC
[jira] Created: (JS2-905) JSP Portlet Decorators:
Decorator-specific decorator.jsp ignored
JSP Portlet Decorators: Decorator-specific decorator.jsp ignored
----------------------------------------------------------------
Key: JS2-905
URL: https://issues.apache.org/jira/browse/JS2-905
Project: Jetspeed 2
Issue Type: Bug
Components: Decorations/Themes
Affects Versions: 2.1.3
Environment: All operating systems, all app servers, all JDKs
Reporter: Aaron Evans
Priority: Minor
Fix For: 2.2
The JSP portlet decorators always use:
jetspeed/decorations/portlet/decorator.jsp
If you have a decorator named "my-decorator", then the layout should check for a file named:
jetspeed/decorations/portlet/my-decorator/decorator.jsp
and if found, use that. Otherwise fall back to the default.
The following info came from Woonsan Ko (thanks!):
BEGIN QUOTE
In the /jetspeed/WEB-INF/templates/layout/html/*/ folders, there are layout.jsp containing the some code fragments like the following:
String _tempPath = _frag.getDecoration().getBasePath();
String _portletJSP = _tempPath.substring(0,_tempPath.lastIndexOf('/')) +
"/decorator.jsp";
I think you can modify the above as follows:
String _portletJSP = "/" + _frag.getDecoration().getResource("decorator.jsp");
END QUOTE
This works well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-905) JSP Portlet Decorators:
Decorator-specific decorator.jsp ignored
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko resolved JS2-905.
----------------------------
Resolution: Fixed
Fixed to use each jsp template of decorations.
By the way, I found that it's not proper to modify PortletDecoratorImpl to do according to the configuration. It's because our current solution implies that templating technology should be the same to serve a page. That is, one portlet fragment should not run on velocity if others are running on jsp. So, fixing jsps only is enough at this time.
> JSP Portlet Decorators: Decorator-specific decorator.jsp ignored
> ----------------------------------------------------------------
>
> Key: JS2-905
> URL: https://issues.apache.org/jira/browse/JS2-905
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Decorations/Themes
> Affects Versions: 2.1.3
> Environment: All operating systems, all app servers, all JDKs
> Reporter: Aaron Evans
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.2
>
> Attachments: jsp_portlet_decorator.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The JSP portlet decorators always use:
> jetspeed/decorations/portlet/decorator.jsp
> If you have a decorator named "my-decorator", then the layout should check for a file named:
> jetspeed/decorations/portlet/my-decorator/decorator.jsp
> and if found, use that. Otherwise fall back to the default.
> The following info came from Woonsan Ko (thanks!):
> BEGIN QUOTE
> In the /jetspeed/WEB-INF/templates/layout/html/*/ folders, there are layout.jsp containing the some code fragments like the following:
> String _tempPath = _frag.getDecoration().getBasePath();
> String _portletJSP = _tempPath.substring(0,_tempPath.lastIndexOf('/')) +
> "/decorator.jsp";
> I think you can modify the above as follows:
> String _portletJSP = "/" + _frag.getDecoration().getResource("decorator.jsp");
> END QUOTE
> This works well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-905) JSP Portlet Decorators:
Decorator-specific decorator.jsp ignored
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632130#action_12632130 ]
Woonsan Ko commented on JS2-905:
--------------------------------
Thank you, Aaron. :)
I think we'd better improve PortletDecorationImpl.getTemplate() method to not use "decorator.vm" literal.
Probably it can read the configuration, and the jsp template should simply use the getTemplate() method.
> JSP Portlet Decorators: Decorator-specific decorator.jsp ignored
> ----------------------------------------------------------------
>
> Key: JS2-905
> URL: https://issues.apache.org/jira/browse/JS2-905
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Decorations/Themes
> Affects Versions: 2.1.3
> Environment: All operating systems, all app servers, all JDKs
> Reporter: Aaron Evans
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.2
>
> Attachments: jsp_portlet_decorator.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The JSP portlet decorators always use:
> jetspeed/decorations/portlet/decorator.jsp
> If you have a decorator named "my-decorator", then the layout should check for a file named:
> jetspeed/decorations/portlet/my-decorator/decorator.jsp
> and if found, use that. Otherwise fall back to the default.
> The following info came from Woonsan Ko (thanks!):
> BEGIN QUOTE
> In the /jetspeed/WEB-INF/templates/layout/html/*/ folders, there are layout.jsp containing the some code fragments like the following:
> String _tempPath = _frag.getDecoration().getBasePath();
> String _portletJSP = _tempPath.substring(0,_tempPath.lastIndexOf('/')) +
> "/decorator.jsp";
> I think you can modify the above as follows:
> String _portletJSP = "/" + _frag.getDecoration().getResource("decorator.jsp");
> END QUOTE
> This works well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Updated: (JS2-905) JSP Portlet Decorators:
Decorator-specific decorator.jsp ignored
Posted by "Aaron Evans (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Evans updated JS2-905:
----------------------------
Attachment: jsp_portlet_decorator.patch
Here is a patch to apply against version 2.1.3 but I'm not sure I did it correctly.
The patch is relative to portal/tags/JETSPEED-RELEASE-2.1.3.
-aaron
> JSP Portlet Decorators: Decorator-specific decorator.jsp ignored
> ----------------------------------------------------------------
>
> Key: JS2-905
> URL: https://issues.apache.org/jira/browse/JS2-905
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Decorations/Themes
> Affects Versions: 2.1.3
> Environment: All operating systems, all app servers, all JDKs
> Reporter: Aaron Evans
> Priority: Minor
> Fix For: 2.2
>
> Attachments: jsp_portlet_decorator.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The JSP portlet decorators always use:
> jetspeed/decorations/portlet/decorator.jsp
> If you have a decorator named "my-decorator", then the layout should check for a file named:
> jetspeed/decorations/portlet/my-decorator/decorator.jsp
> and if found, use that. Otherwise fall back to the default.
> The following info came from Woonsan Ko (thanks!):
> BEGIN QUOTE
> In the /jetspeed/WEB-INF/templates/layout/html/*/ folders, there are layout.jsp containing the some code fragments like the following:
> String _tempPath = _frag.getDecoration().getBasePath();
> String _portletJSP = _tempPath.substring(0,_tempPath.lastIndexOf('/')) +
> "/decorator.jsp";
> I think you can modify the above as follows:
> String _portletJSP = "/" + _frag.getDecoration().getResource("decorator.jsp");
> END QUOTE
> This works well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-905) JSP Portlet Decorators:
Decorator-specific decorator.jsp ignored
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko reassigned JS2-905:
------------------------------
Assignee: Woonsan Ko
> JSP Portlet Decorators: Decorator-specific decorator.jsp ignored
> ----------------------------------------------------------------
>
> Key: JS2-905
> URL: https://issues.apache.org/jira/browse/JS2-905
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Decorations/Themes
> Affects Versions: 2.1.3
> Environment: All operating systems, all app servers, all JDKs
> Reporter: Aaron Evans
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.2
>
> Attachments: jsp_portlet_decorator.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The JSP portlet decorators always use:
> jetspeed/decorations/portlet/decorator.jsp
> If you have a decorator named "my-decorator", then the layout should check for a file named:
> jetspeed/decorations/portlet/my-decorator/decorator.jsp
> and if found, use that. Otherwise fall back to the default.
> The following info came from Woonsan Ko (thanks!):
> BEGIN QUOTE
> In the /jetspeed/WEB-INF/templates/layout/html/*/ folders, there are layout.jsp containing the some code fragments like the following:
> String _tempPath = _frag.getDecoration().getBasePath();
> String _portletJSP = _tempPath.substring(0,_tempPath.lastIndexOf('/')) +
> "/decorator.jsp";
> I think you can modify the above as follows:
> String _portletJSP = "/" + _frag.getDecoration().getResource("decorator.jsp");
> END QUOTE
> This works well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org