You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/05/11 13:50:35 UTC
[GitHub] [nifi] NissimShiman opened a new pull request, #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
NissimShiman opened a new pull request, #6035:
URL: https://github.com/apache/nifi/pull/6035
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-9440](https://issues.apache.org/jira/browse/NIFI-9440)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1165545952
Also, forgot to mention that the bulletins are set up from the Settings tab when configuring Controller Services.
I attached a picture to the jira ticket circling the location for setting the new functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1164753180
@mattyb149 I was wondering if you could take a look at this again.
I have a (hopefully less complex) example at the end of the last comment where the
ElasticSearchClientServiceImpl service can be set up to generate ERROR bulletins
I just noticed that bulletins can be delayed on the main nifi graph, but if a refresh is done they should be seen immediately from the Bulletins icon (right below the Global menu)
They can also be seen via:
Global Menu -> Bulletin Board
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
URL: https://github.com/apache/nifi/pull/6035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1148665871
@mattyb149 thank you very much for looking at this!
I just tried with IPLookupService using a blank file for the MaxMind Database File property and was able to turn on the controller service .. well it goes in to the "Enabling" state ... not quite "Enabled".
There *should* be bulletins every 30 seconds on the main nifi graph. There should be a red box right under the global menu and to the right of the Search icon/magnifying glass that should have a new bulletin every 30 seconds saying this file is invalid.
I will look around and see if there are other controller services that can be set to emit error or warn bulletins with minimal configuration...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markobean commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
markobean commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1131972414
This looks really good. I could find nothing wrong with the expected behavior as well as compatibility issues which were well-thought out. Here are some of the tests I performed:
Changed this PR's code to modify a controller service (CS), specifically CSVReader, to issue DEBUG, INFO, WARN and ERROR log messages when enabled. Built and installed.
Instantiated CSVReader within a process group (PG) and set the Bulletin Level to DEBUG
Enabled the CS and observed all four bulletins on the PG's listing of Controller Services. Also observed them on the Bulletin Board.
Repeat, changing the Bulletin Level to INFO, then WARN, then ERROR. All confirmed to behave as expected with bulletin visibility.
Copy/paste the PG.
> The bulletin level for the CS remained as DEBUG, and behavior confirmed.
Version controlled the PG to NiFi Registry of this PR (1.17.0-SNAPSHOT). Then, instantiated the flow from Registry.
> The bulletin level for the CS remained as DEBUG, and behavior confirmed.
Version controlled the PG to NiFi Registry, 1.16.1. Then, instantiated the flow from Registry.
> The bulletin level for the CS returned to WARN as expected, and corresponding behavior confirmed.
For backward compatibility, installed NiFi 1.16.1 placing flow.xml.gz and flow.json.gz in the conf directory (and other required config updates to enable NIFi to start.) NiFi started without issue. CS issued bulletins at the WARN level.
The only comment is that TRACE is not an option. However, it is not a Bulletin Level option for processors either, so I think this is fine. If you're interested in TRACE level, you're probably looking at - or have the ability to look at - the log file directly.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1138649678
There are merge conflicts now that need to be resolved, then I will review, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1123915097
As this change touches a wide range of apache nifi core files/functionality, extensive edge testing was done to verify the integrity of this new functionality, especially with regards to backward compatibility with flow configurations from apache nifi 1.16.x where this functionality does not exist.
flow.xml.gz / flow.json.xml from earlier versions can be dropped into the conf directory and on nifi restart, any controller services in these files will have tags added to reflect a bulletinLevel at the WARN level (to maintain backward compatibility where WARN was previously globally set [1])
Templates from previous nifi versions can be used and nifi will start up and will modify any controller services in these files (and their definitions in the flow.xml.gz/flow.json.gz) to have a bulletinLevel at the WARN level
nifi-registry (on 1.17 and later) can be updated using flow_storage and database directories from registries of 1.16.x and controller services in flows that are brought over will have bulletinLevel set at WARN level. Their definitions in the flow.xml.gz/flow.json.gz will be gracefully updated to reflect this. The registry will also remain "up to date" at the latest version when this done as well.
[1] https://github.com/apache/nifi/blob/rel/nifi-1.16.1/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/flow/StandardFlowManager.java#L489-L490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1168821231
+1 LGTM, I was able to verify on a couple of scenarios. Thanks for the improvement and for sticking with this PR! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1170451341
Thank you @mattyb149 and @markobean for looking this over!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1147524642
I'm having trouble validating this, I tried with an IPLookupService as described in the Jira, but leaving the MaxMind file blank just makes the CS invalid as this is a required property. How do I set this up so I can see the bulletins, and where should I see them? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1138864975
@ mattyb149 Good point. This has now been resolved. Thank You!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org