[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #610: HDDS-2929. Implement ofs://: temp directory mount

[GitBox <gi...@apache.org>]

timmylicheng commented on a change in pull request #610: HDDS-2929. Implement ofs://: temp directory mount
URL: https://github.com/apache/hadoop-ozone/pull/610#discussion_r385064366
 
 

 ##########
 File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
 ##########
 @@ -67,10 +75,9 @@ private void initOFSPath(String pathStr) {
       // TODO: Compare a keyword list instead for future expansion.
       if (firstToken.equals(OFS_MOUNT_NAME_TMP)) {
         mountName = firstToken;
-        // TODO: Retrieve volume and bucket of the mount from user protobuf.
-        //  Leave them hard-coded just for now. Will be addressed in HDDS-2929
-        volumeName = "tempVolume";
-        bucketName = "tempBucket";
+        // Future: retrieve volume and bucket from UserVolumeInfo
+        volumeName = OFS_MOUNT_TMP_VOLUMENAME;
+        bucketName = getTempMountBucketName(null);
 
 Review comment:
   Is it better to have a 'DEFAULT_USER' string to replace a null input?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org