[GitHub] libcloud pull request #1209: added c5.* m5.* instance types to all appropria...

[yanowitz <gi...@git.apache.org>]

GitHub user yanowitz opened a pull request:

    https://github.com/apache/libcloud/pull/1209

       added c5.* m5.* instance types to all appropriate regions

    ## Adds c5.* and m5.* for all AWS regions in which the instances are available.
    
    ### Description
    
    Since the original c5.* and m5.* were added to libcloud, they have become available in more regions.
    
    There were some tests that asserted the length of various lists of instance types. I removed these tests as they are quite brittle and simply test that the code says what the code says.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [ ] Documentation
    - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanowitz/libcloud add_c5_m5_to_more_regions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1209
    
----
commit ab2eb3d9e6cb4d8d48cbfd3ac3f12eb6ea453416
Author: Jason Yanowitz <jy...@...>
Date:   2018-05-10T20:13:38Z

       added c5.* m5.* instance types to all appropriate regions
       remove brittle tests

----


---

[GitHub] libcloud pull request #1209: added AWS c5.* m5.* instance types to all appro...

[yanowitz <gi...@git.apache.org>]

Github user yanowitz closed the pull request at:

    https://github.com/apache/libcloud/pull/1209


---