[GitHub] [ratis] SincereXIA edited a comment on pull request #616: RATIS-1545. RaftLogOutputStream support async flush.

[GitBox <gi...@apache.org>]

SincereXIA edited a comment on pull request #616:
URL: https://github.com/apache/ratis/pull/616#issuecomment-1059143121


   > @SincereXIA , could you try also async flush with 3s flush interval? It seems that ExecutorService and single thread are supposed to have the same performance. Thanks.
   
   Hi @szetszwo , I tried increasing the interval between async flushes like this: https://github.com/SincereXIA/ratis/commit/118b2e5ec5339b2fb105c29e738c066644112d59
   
   and I repeated the test, but I couldn't find a difference in performance by use 3s flush interval. The average write time is almost the same as the last column in the table. 
   
   I think maybe the time it takes to create the async task is causing the slight drop in performance.
   
   By the way, is it a good idea to add a configurable flush interval? If yes, I can add it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org