You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (JIRA)" <ji...@apache.org> on 2013/01/08 21:48:13 UTC
[jira] [Comment Edited] (LUCENE-4665) Upgrade ICU4J to newest
version
[ https://issues.apache.org/jira/browse/LUCENE-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547238#comment-13547238 ]
Shawn Heisey edited comment on LUCENE-4665 at 1/8/13 8:46 PM:
--------------------------------------------------------------
I had to manually hack the patch that svn created to make the sha1 file changes work, but here it is. Using gnu patch, the hacked patch didn't delete the old sha1 file, just made it zero bytes. With the patch capability in TortoiseSVN, it worked properly.
was (Author: elyograg):
I had to manually hack the patch that svn created to make the sha1 file changes work, but here it is.
> Upgrade ICU4J to newest version
> -------------------------------
>
> Key: LUCENE-4665
> URL: https://issues.apache.org/jira/browse/LUCENE-4665
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.0
> Reporter: Shawn Heisey
> Fix For: 4.2, 5.0
>
> Attachments: icu4j-50-4x.patch, icu4j-50-trunk.patch, LUCENE-4665-4x.patch, LUCENE-4665-trunk.patch
>
>
> Upgrade ICU4J to the latest version - 50.1.1 at the moment.
> DictionaryBasedBreakIterator was eliminated by the upgrade, so some very small code changes were required. All tests (including nightly and weekly) passed with patch. I did not try running tests multiple times. The branch_4x tests were run on Windows, where I run eclipse. The trunk tests were run on Linux, the platform where I actually use Solr.
> I have no idea whether the ICU tests are comprehensive enough to detect problems with version upgrades.
> It is possible that I don't have enough knowledge to complete this upgrade properly. I did my best.
> A couple of javadocs mentioned the removed class. I changed one (hopefully correctly), but didn't know what the other should say.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org