[jira] [Resolved] (REEF-262) Group Communication should take Configurations, not Types

["Markus Weimer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Weimer resolved REEF-262.
--------------------------------
       Resolution: Implemented
    Fix Version/s: 0.11

This is resolved in [#151|https://github.com/apache/incubator-reef/pull/151]

> Group Communication should take Configurations, not Types
> ---------------------------------------------------------
>
>                 Key: REEF-262
>                 URL: https://issues.apache.org/jira/browse/REEF-262
>             Project: REEF
>          Issue Type: Improvement
>          Components: GroupCommunications, REEF.NET
>            Reporter: Markus Weimer
>            Assignee: Julia
>            Priority: Blocker
>             Fix For: 0.11
>
>
> In the group communications library, we today require the user to give us the types of Codecs and ReduceFunction. This creates issues when those types themselves require parameters. Instead, we could use instances of {{Configuration}} to capture the information which type to instantiate as well as its parameters.
> Example: Today, we have the following:
> {code:Title=ICommunicationGroupDriver.cs}
> ICommunicationGroupDriver AddReduce<TMessage, TMessageCodec>(string operatorName, string masterTaskId, IReduceFunction<TMessage> reduceFunction, TopologyTypes topologyType = TopologyTypes.Flat) where TMessageCodec : ICodec<TMessage>;
> {code}
> This would be turned into:
> {code:Title=ICommunicationGroupDriver.cs}
> ICommunicationGroupDriver AddReduce(string operatorName, string masterTaskId, IConfiguration configuration, TopologyTypes topologyType = TopologyTypes.Flat);
> {code}
> Here, we'd assume that {{configuration}} contains the needed bindings for both the reduce function and the codec.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)