[jira] Commented: (MDEP-300) Unpacking artifacts should be based on type, not on extension

["Benjamin Bentmann (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MDEP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254689#action_254689 ] 

Benjamin Bentmann commented on MDEP-300:
----------------------------------------

Unless I misunderstand, this change would break unpacking of deps of type {{test-jar}}, {{bundle}} or any other type that effectively maps to a JAR or any other well-known file extension. So maybe either both file ext and dep type should be tried to lookup the archiver or {{ArtifactItem}} should be enriched with a new field, e.g. {{archiveType}}, that allows to explicitly denote the desired archiver type.

> Unpacking artifacts should be based on type, not on extension
> -------------------------------------------------------------
>
>                 Key: MDEP-300
>                 URL: http://jira.codehaus.org/browse/MDEP-300
>             Project: Maven 2.x Dependency Plugin
>          Issue Type: Bug
>          Components: unpack, unpack-dependencies
>    Affects Versions: 2.1
>            Reporter: Robert Scholte
>            Assignee: Brian Fox
>            Priority: Critical
>         Attachments: typebased-unpack.patch
>
>
> I've defined a custom lifecycle with a new packaging type "custom-ear". This type is generated by calling some external tool, which generates a (non java) ear-file. During the {{pre-integration-test}} I need to unpack it. Since {{dependency:unpack}} and {{dependecy:unpack-dependencies}} is based on the extension I'm not able to specify my own unArchiver. 
> Attached a patch which should fix this problem.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira