You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2014/11/08 12:35:38 UTC
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/3170
SPARK-948 [WEB UI] Move "Classpath Entries" in WebUI
This is a trivial change that resolves SPARK-948. Feel free to reject it too if there's not agreement on it, and then the JIRA can be closed. Just proposing it to resolve the question.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3170
----
commit 865fb5a23cc27c1dd3031a9f970605560ad6c35a
Author: Sean Owen <so...@cloudera.com>
Date: 2014-11-08T11:34:04Z
Move up Classpath Entries in Environment tab
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3170#issuecomment-62254881
[Test build #23100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23100/consoleFull) for PR 3170 at commit [`865fb5a`](https://github.com/apache/spark/commit/865fb5a23cc27c1dd3031a9f970605560ad6c35a).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3170#issuecomment-62257227
[Test build #23100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23100/consoleFull) for PR 3170 at commit [`865fb5a`](https://github.com/apache/spark/commit/865fb5a23cc27c1dd3031a9f970605560ad6c35a).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3170#issuecomment-63610219
Sure, I don't mind either way. I was implementing the one-liner to resolve the issue one way or the other. Hm, is it then weird to split Spark and System properties just for this? I'd just leave it as-is if a change is not clearly an improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by srowen <gi...@git.apache.org>.
Github user srowen closed the pull request at:
https://github.com/apache/spark/pull/3170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3170#issuecomment-62257228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23100/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-948 [WEB UI] Move "Classpath Entries" in...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3170#issuecomment-63608930
@srowen this seems reasonable, but what about moving it right _after_ spark properties? I sort of like having the spark settings front-and-center since I think a common case is to go here and understand which settings are in effect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org