You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by karuppayya <gi...@git.apache.org> on 2016/11/29 16:41:01 UTC
[GitHub] zeppelin pull request #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in...
GitHub user karuppayya opened a pull request:
https://github.com/apache/zeppelin/pull/1702
[ZEPPELIN-1727] Shift + Enter runs two paras in particular scenario
### What is this PR for?
1. click *insert new* in p1(say code in p1 is %sh date -u )
2. New para p2 is created and cursor is on the p2 editor.
3. Type code say %sh date -u and press shift + enter.(without clicking on p2's editor)
The output of p1 and p2 will be same, p2 run triggered p1's run as well.
This PR fixes the above scenario
### What type of PR is it?
Bug fix
### Todos
NA
### What is the Jira issue?
### How should this be tested?
The steps mentioned in description of PR need s to be tested
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? NA
* Does this needs documentation? NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karuppayya/incubator-zeppelin ZEPPELIN-1727
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1702
----
commit 3dd7a5dac9ae47c7cdaac105b0c766b5649e844f
Author: karuppayya <ka...@gmail.com>
Date: 2016-11-29T16:24:31Z
Fix para focus
Signed-off-by: karuppayya <ka...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in partic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1702
Tested and it works well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1702
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in partic...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1702
That's a good fix!
I have a personal oppinion.
How about moving the `focusParagraph` event` broadcast` to the link below?
https://github.com/karuppayya/incubator-zeppelin/blob/3dd7a5dac9ae47c7cdaac105b0c766b5649e844f/zeppelin-web/src/app/notebook/notebook.controller.js#L367
In my opinion, there should be a `focusParagraph` event in the matching part that checks the id of the paragraph.
It seems to be safer.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1702: [ZEPPELIN-1727] Shift + Enter runs two paras in partic...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1702
Merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---