You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/18 10:39:18 UTC

[jira] [Commented] (FLINK-3433) Return value from ObjectInputStream#read() should be checked in AvroOutputFormat#readObject

    [ https://issues.apache.org/jira/browse/FLINK-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152017#comment-15152017 ] 

ASF GitHub Bot commented on FLINK-3433:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1666

    [FLINK-3433] AvroOutputFormat#readObject uses readFully()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3433_avro_read

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1666
    
----
commit af812eee2e94dfa75421f5ec652cbb20e3657aec
Author: zentol <s....@web.de>
Date:   2016-02-18T09:37:49Z

    [FLINK-3433] AvroOutputFormat#readObject uses readFully()

----


> Return value from ObjectInputStream#read() should be checked in AvroOutputFormat#readObject
> -------------------------------------------------------------------------------------------
>
>                 Key: FLINK-3433
>                 URL: https://issues.apache.org/jira/browse/FLINK-3433
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> Here is related code:
> {code}
>     if(length != 0) {
>       byte[] json = new byte[length];
>       in.read(json);
>       Schema schema = new Schema.Parser().parse(new String(json));
> {code}
> The return value from in.read() should be verified against length.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)