You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/11 09:25:06 UTC
[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request
#1070: [CALCITE-2808]Add the JSON_LENGTH function
XuQianJin-Stars commented on a change in pull request #1070: [CALCITE-2808]Add the JSON_LENGTH function
URL: https://github.com/apache/calcite/pull/1070#discussion_r264144872
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5300,6 +5302,30 @@ SqlCall JsonDepthFunctionCall() :
}
}
+SqlCall JsonLengthFunctionCall() :
+{
+ final SqlNode[] args = new SqlNode[1];
+ SqlNode e;
+ final Span span;
+ List<SqlNode> behavior;
+}
+{
+ <JSON_LENGTH> { span = span(); }
+ <LPAREN> [
Review comment:
hi @zhztheplayer Sorry for the late reply. `JSON_LENGTH(json_doc[, path])` calcite is semantically supported. I hope you can help me. I don't quite understand the implementation of `JsonApiCommonSyntax()`, but my idea is to take this `JsonApiCommonSyntax()` and tweak it to take care of the `JSON_LENGTH` syntax.
best
qianjin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services