You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/05/11 03:14:04 UTC
[GitHub] [yunikorn-core] zhuqi-lucas opened a new pull request, #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
zhuqi-lucas opened a new pull request, #542:
URL: https://github.com/apache/yunikorn-core/pull/542
### What is this PR for?
updateAllocatedAndPendingResourceMetrics should support all queue types
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1553
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #542:
URL: https://github.com/apache/yunikorn-core/pull/542#issuecomment-1545225925
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/542?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#542](https://app.codecov.io/gh/apache/yunikorn-core/pull/542?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f0f4a2) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/8664ce2b584c41fbfe3ea4aa41634d48214295d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8664ce2) will **decrease** coverage by `0.11%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 75.06% 74.96% -0.11%
==========================================
Files 70 70
Lines 11332 11366 +34
==========================================
+ Hits 8506 8520 +14
- Misses 2529 2545 +16
- Partials 297 301 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/queue.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/542?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `76.89% <100.00%> (-0.02%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/542/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on a diff in pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #542:
URL: https://github.com/apache/yunikorn-core/pull/542#discussion_r1191938702
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1482,16 +1482,14 @@ func (sq *Queue) updateMaxResourceMetrics() {
// updateAllocatedAndPendingResourceMetrics updates allocated and pending resource metrics if this is a leaf queue.
func (sq *Queue) updateAllocatedAndPendingResourceMetrics() {
Review Comment:
please update comment also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] zhuqi-lucas commented on a diff in pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #542:
URL: https://github.com/apache/yunikorn-core/pull/542#discussion_r1191943978
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1482,16 +1482,14 @@ func (sq *Queue) updateMaxResourceMetrics() {
// updateAllocatedAndPendingResourceMetrics updates allocated and pending resource metrics if this is a leaf queue.
func (sq *Queue) updateAllocatedAndPendingResourceMetrics() {
Review Comment:
Addressed it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko closed pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
URL: https://github.com/apache/yunikorn-core/pull/542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] zhuqi-lucas commented on a diff in pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on code in PR #542:
URL: https://github.com/apache/yunikorn-core/pull/542#discussion_r1191942764
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1482,16 +1482,14 @@ func (sq *Queue) updateMaxResourceMetrics() {
// updateAllocatedAndPendingResourceMetrics updates allocated and pending resource metrics if this is a leaf queue.
func (sq *Queue) updateAllocatedAndPendingResourceMetrics() {
Review Comment:
Sure @wilfred-s , sorry for missing this comment change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] pbacsko commented on pull request #542: [YUNIKORN-1553] updateAllocatedAndPendingResourceMetrics should support all queue types
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko commented on PR #542:
URL: https://github.com/apache/yunikorn-core/pull/542#issuecomment-1546076846
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org