You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/14 08:26:46 UTC

[GitHub] [apisix] kwanhur commented on a diff in pull request #7041: feat(xrpc): register variable redis_cmd_line

kwanhur commented on code in PR #7041:
URL: https://github.com/apache/apisix/pull/7041#discussion_r872951293


##########
docs/en/latest/apisix-variable.md:
##########
@@ -39,5 +39,6 @@ List in alphabetical order:
 | route_name       | core    | name of `route`        |   |
 | service_id       | core    | id of `service`        |   |
 | service_name     | core    | name of `service`      |   |
+| redis_cmd_line   | Redis   | the content of Redis command |   |

Review Comment:
   Better shorten name `redis_cmd` or `redis_command`?
   
   `redis_cmd_line` seems it'll return multi commands compact into one line. It just return one total command content, not just a redis command like `hmset`, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org