You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/07 06:59:57 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request #1724: Update release candidate script
ctubbsii opened a new pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724
Improving generated output:
* show link to staging repo website
* show full commits
* show reminders of which buttons to click on the staging site
* show reminder to replace `$origin` with actual remote name
* place `-s` in `git tag` command with the other options
* update draft release notes link to point to staged site
Optimizing performance:
* create the `-next` branch and switch to it in one command
* skip tests during release prep because the release can (and should) be
tested outside of the actual release candidate creation process and
this speeds things up significantly
* change release prep goal to only do `package`, because it's not
necessary to run `verify` during `release:prepare`; all the QA checks
done at `verify` can be done before/after release candidate staging
Being more interactive:
* prompt for gpg key to use
* prompt for the `remote` to push to (do not assume `origin`)
Removing junk:
* remove check for `gpg2` (modern Linux uses version 2 for the `gpg` binary)
* remove unnecessary `--test` option and related `runOrFail` function
* remove `extraReleaseArguments` to simplify things
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724#discussion_r501177364
##########
File path: assemble/build.sh
##########
@@ -72,8 +74,43 @@ gitCommits() { pretty %H "$@"; }
gitCommit() { gitCommits -n1 "$@"; }
gitSubject() { pretty %s "$@"; }
+selectFingerprint() {
+ local f fingerprints=()
+ if [[ $SELECTED_FINGERPRINT =~ ^[0-9a-fA-F]{40}$ ]]; then
+ # it's already set, don't set it again
+ return 0
+ fi
+ mapfile -t fingerprints < <(gpg --list-secret-keys --with-colons --with-fingerprint 2>/dev/null | awk -F: '$1 == "fpr" {print $10}')
+ fingerprints+=('Other')
+ echo
+ echo "Select the $(green gpg) key to use:"
+ COLUMNS=1
+ select f in "${fingerprints[@]}"; do
+ if [[ -z $f ]]; then
+ return 1
+ elif [[ $f == 'Other' ]]; then
+ SELECTED_FINGERPRINT=$(prompter "$(green gpg) key's $(green fingerprint)" '[0-9a-fA-F]{40}')
+ return 0
+ else
+ SELECTED_FINGERPRINT="$f"
+ return 0
+ fi
+ done
+}
+
Review comment:
Yeah, it helps me, too, because I have several subkeys, and before this change, it was putting all three in the email and I had to delete the extras. Now, I just have to pick the correct one. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724#issuecomment-705052382
> Looks good. I did not test it though. Were you able to test it in some way?
Yes. I exercised it several times uploading to the staging repo, and then deleting the artifacts and trying again after changes. I used my fork to test the uploading of the branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724#issuecomment-705085072
Merged to main branch in 80ee9ca8092dc4bf07aa1a046d6e668f0e16300e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724#discussion_r501069477
##########
File path: assemble/build.sh
##########
@@ -72,8 +74,43 @@ gitCommits() { pretty %H "$@"; }
gitCommit() { gitCommits -n1 "$@"; }
gitSubject() { pretty %s "$@"; }
+selectFingerprint() {
+ local f fingerprints=()
+ if [[ $SELECTED_FINGERPRINT =~ ^[0-9a-fA-F]{40}$ ]]; then
+ # it's already set, don't set it again
+ return 0
+ fi
+ mapfile -t fingerprints < <(gpg --list-secret-keys --with-colons --with-fingerprint 2>/dev/null | awk -F: '$1 == "fpr" {print $10}')
+ fingerprints+=('Other')
+ echo
+ echo "Select the $(green gpg) key to use:"
+ COLUMNS=1
+ select f in "${fingerprints[@]}"; do
+ if [[ -z $f ]]; then
+ return 1
+ elif [[ $f == 'Other' ]]; then
+ SELECTED_FINGERPRINT=$(prompter "$(green gpg) key's $(green fingerprint)" '[0-9a-fA-F]{40}')
+ return 0
+ else
+ SELECTED_FINGERPRINT="$f"
+ return 0
+ fi
+ done
+}
+
Review comment:
The prompt to select the fingerprint is nice, this was something I missed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1724: Update release candidate script
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1724:
URL: https://github.com/apache/accumulo/pull/1724#issuecomment-704738161
These changes should make the release process slightly better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org