[GitHub] [ozone] hemantk-12 commented on a diff in pull request #4948: HDDS-8408. [Snapshot] Implement 'ozone fs' command for deleting snapshots

["hemantk-12 (via GitHub)" <gi...@apache.org>]

hemantk-12 commented on code in PR #4948:
URL: https://github.com/apache/ozone/pull/4948#discussion_r1237802048


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFsSnapshot.java:
##########
@@ -285,6 +285,19 @@ public void testDeleteBucketWithSnapshot() throws Exception {
     Assertions.assertTrue(listSnapKeyOut.contains(snapshotKeyPath));
   }
 
+  @Test
+  public void testSnapshotDeleteSuccessAndFailure() throws Exception {

Review Comment:
   nit: I prefer to test only one thing in a test. Also by making `deleteSnapshot()` another function you are delegating test to another function. Better way would have been to have two different test one for success and one for failure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org