You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2023/06/12 16:42:50 UTC
[GitHub] [airflow] o-nikolas commented on a diff in pull request #31838: Various fixes on ECS run task operator
o-nikolas commented on code in PR #31838:
URL: https://github.com/apache/airflow/pull/31838#discussion_r1226937588
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -506,25 +515,24 @@ def execute(self, context, session=None):
@AwsBaseHook.retry(should_retry_eni)
def _start_wait_check_task(self, context):
-
if not self.arn:
self._start_task(context)
+ if not self.wait_for_completion:
+ return
+
Review Comment:
Whatever logs users were getting for the short period of time without a wait_for_completion they will no longer get. So we're calling it a bug fix with no deprecation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org