You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/10/18 05:57:00 UTC

[GitHub] [buildstream] gtristan commented on pull request #1777: setup.py: Stop including generated Cython code in source distributions.

gtristan commented on PR #1777:
URL: https://github.com/apache/buildstream/pull/1777#issuecomment-1281850816

   Investigating further, it appears that this should not be required.
   
   The issue we ran into in particular was with `_PyGen_Send` missing in 3.10, which is handled by cython in: https://github.com/cython/cython/commit/782a87336d88496b022bf0f2791c818221f4743a
   
   If I'm reading this correctly, then the generated code should support `cpython <= 3.10` after this fix.
   
   Were we to follow the upstream intentions (as I think I understand them now), then we would have set a minimal bound build time dependency on Cython when adding support for python 3.10 in BuildStream.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org