You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jjz921024 (via GitHub)" <gi...@apache.org> on 2023/02/24 02:34:26 UTC

[GitHub] [incubator-kvrocks] jjz921024 opened a new issue, #1278: For the expired key, the TYPE command returns dirty data

jjz921024 opened a new issue, #1278:
URL: https://github.com/apache/incubator-kvrocks/issues/1278

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Version
   
   kvrocks v2.3.0
   
   ### Minimal reproduce step
   
   ```
   127.0.0.1:31001> set k v ex 10
   OK
   127.0.0.1:31001> type k
   "string"
   127.0.0.1:31001> ttl k
   (integer) 3
   127.0.0.1:31001> ttl k
   (integer) -2
   127.0.0.1:31001> type k
   "string"
   127.0.0.1:31001> get k
   (nil)
   127.0.0.1:31001> type k
   "string"
   ```
   
   ### What did you expect to see?
   
   **None** should been returned for the expired key
   
   ### What did you see instead?
   
   For the expired key, the TYPE command returns dirty data
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1278: For the expired key, the TYPE command returns dirty data

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1278:
URL: https://github.com/apache/incubator-kvrocks/issues/1278#issuecomment-1445401501

   Hi @Lericaro
   
   This bug was caused by the type command didn't check the expiry time, and it's OK to recycle those expired items later by compaction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1278: For the expired key, the TYPE command returns dirty data

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1278:
URL: https://github.com/apache/incubator-kvrocks/issues/1278#issuecomment-1442713745

   @jjz921024 Thanks for your good catch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] Lericaro commented on issue #1278: For the expired key, the TYPE command returns dirty data

Posted by "Lericaro (via GitHub)" <gi...@apache.org>.
Lericaro commented on issue #1278:
URL: https://github.com/apache/incubator-kvrocks/issues/1278#issuecomment-1445398959

   rocksdb has a feature whereby an expired key is not removed immediately but during compaction. If the size of a specific level is not large enough to trigger compaction, the old data remains. Compacting manually is one possible solution, but it may cause write stalls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice closed issue #1278: For the expired key, the TYPE command returns dirty data

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice closed issue #1278: For the expired key, the TYPE command returns dirty data
URL: https://github.com/apache/incubator-kvrocks/issues/1278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org