You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Alexander Rettig (JIRA)" <ji...@codehaus.org> on 2011/01/05 19:51:58 UTC

[jira] Created: (MASSEMBLY-538) filtering broken in files containing '@'

filtering broken in files containing '@'
----------------------------------------

                 Key: MASSEMBLY-538
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
    Affects Versions: 2.2
         Environment: mvn -v
Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
Java version: 1.6.0_22
Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"

            Reporter: Alexander Rettig
            Priority: Minor
         Attachments: filter-test-1.0.zip

Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.

To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run

mvn assembly:single

The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=254594#action_254594 ] 

Dennis Lundberg commented on MASSEMBLY-538:
-------------------------------------------

Updated to maven-filtering 1.0-SNAPSHOT in [r1066942|http://svn.apache.org/viewvc?view=revision&revision=1066942].
New 2.2.1-SNAPSHOT of the assembly plugin deployed. Please test it.

> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MASSEMBLY-538.
-------------------------------------

    Resolution: Fixed

The supplied sample project works if I update maven-assembly-plugin to 2.2.1-SNAPSHOT.

> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253926#action_253926 ] 

Dennis Lundberg commented on MASSEMBLY-538:
-------------------------------------------

To fix this we need to update to maven-filtering 1.0.

> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MASSEMBLY-538:
--------------------------------------

    Fix Version/s: 2.3
         Assignee: Dennis Lundberg

> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.3
>
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "TJ Rothwell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253912#action_253912 ] 

TJ Rothwell commented on MASSEMBLY-538:
---------------------------------------

I noticed this with .bat files. Since ${var} and @var@ both work, I think it has to do with the pattern matching. This should be a highly severity level.

<file-doesn't work>
@echo off
${cmd} ${args}


<file-workaround>
@echo off
rem @ (matching @)
${cmd} ${args}


> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Priority: Minor
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "TJ Rothwell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253912#action_253912 ] 

TJ Rothwell edited comment on MASSEMBLY-538 at 2/2/11 3:50 PM:
---------------------------------------------------------------

I noticed this with .bat files. Since ${var} and @var@ both work, I think it has to do with the pattern matching. This should be a higher severity level.

<file-doesn't work>
@echo off
${cmd} ${args}


<file-workaround>
@echo off
rem @ (matching 'at')
${cmd} ${args}


      was (Author: tjrothwell):
    I noticed this with .bat files. Since ${var} and @var@ both work, I think it has to do with the pattern matching. This should be a highly severity level.

<file-doesn't work>
@echo off
${cmd} ${args}


<file-workaround>
@echo off
rem @ (matching @)
${cmd} ${args}

  
> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Priority: Minor
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-538) filtering broken in files containing '@'

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MASSEMBLY-538:
--------------------------------------

    Fix Version/s:     (was: 2.3)
                   2.2.1

> filtering broken in files containing '@'
> ----------------------------------------
>
>                 Key: MASSEMBLY-538
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-538
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: mvn -v
> Apache Maven 2.2.1 (rNON-CANONICAL_2010-08-13_17-44_abuild; 2010-08-13 19:44:44+0200)
> Java version: 1.6.0_22
> Java home: /usr/lib64/jvm/java-1.6.0-sun-1.6.0/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux" version: "2.6.34.7-0.7-desktop" arch: "amd64" Family: "unix"
>            Reporter: Alexander Rettig
>            Assignee: Dennis Lundberg
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: filter-test-1.0.zip
>
>
> Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.
> To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run
> mvn assembly:single
> The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of ${project.artifactId} replaced, but not the second one.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira