[GitHub] [incubator-nuttx-apps] GUIDINGLI commented on a change in pull request #385: apps/MAKE: Add register staging to context

[GitBox <gi...@apache.org>]

GUIDINGLI commented on a change in pull request #385:
URL: https://github.com/apache/incubator-nuttx-apps/pull/385#discussion_r489148926



##########
File path: Makefile
##########
@@ -152,13 +156,12 @@ endif # CONFIG_BUILD_KERNEL
 dirlinks:
 	$(Q) $(MAKE) -C platform dirlinks TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
 
-context_rest: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+context_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_context)
+register_all: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_register)
 
-context_serialize:
-	$(Q) $(MAKE) -C builtin context TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"

Review comment:
       
   the special case of running context on builtin first, is useless, so I removed.
   
   You can see there is no "context:: " in builtin/Makefile, then it will use common context:: in Application.mk.
   That is do the action of register, but builtin folder has no PROGNAME itself.
   
   so we can remove this:
   $(Q) $(MAKE) -C builtin context TOPDIR="$(TOPDIR)" APPDIR="$(APPDIR)"
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org