[PR] Make prompting work in the daemon [maven-mvnd]

["oehme (via GitHub)" <gi...@apache.org>]

oehme opened a new pull request, #1303:
URL: https://github.com/apache/maven-mvnd/pull/1303

   The daemon was implementing the legacy plexus.interactivity Prompter interface, which Maven 4 no longer calls. Instead, it needs to implement the new maven.api Prompter interface. This also simplifies the code, since the legacy prompter handling is now done by Maven core and it delegates to the new interface if an old plugin uses it.
   
   Also, prompting was skipped on dumb terminals for some reason. This meant that prompting could not be tested with automated tests using ProcessBuilder. It also meant that piping input into mvnd on the terminal wouldn't work. This made it inconsistent with regular Maven, which supports prompting on a dumb terminal. I've reactivated it, which makes the prompting integration tests for our Maven extension pass again.
   
   There was also a missing console flush before sending the response to the daemon, which could lead to inconsistent output, where the newline was sometimes printed before and sometimes after the next line from the daemon.
   
   Fixes #1292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Make prompting work in the daemon [maven-mvnd]

["oehme (via GitHub)" <gi...@apache.org>]

oehme commented on PR #1303:
URL: https://github.com/apache/maven-mvnd/pull/1303#issuecomment-2759685488

   Ah, the failure is because the [legacy support in maven-core](https://github.com/apache/maven/blob/master/compat/maven-compat/src/main/java/org/apache/maven/internal/compat/interactivity/LegacyPlexusInteractivity.java#L46) is broken and doesn't do what it says in the Javadoc. It's supposed to delegate to the Maven 4 API, but instead it delegates to an implementation detail. So that'll have to be fixed as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org