[GitHub] [flink] snuyanzin commented on a diff in pull request #19638: [FLINK-27490][table][tests] Migrate test to JUnit5 for flink-table-co…

[GitBox <gi...@apache.org>]

snuyanzin commented on code in PR #19638:
URL: https://github.com/apache/flink/pull/19638#discussion_r865698657


##########
flink-table/flink-table-code-splitter/src/test/java/org/apache/flink/table/codesplit/JavaCodeSplitterTest.java:
##########
@@ -20,28 +20,28 @@
 import org.apache.flink.core.testutils.FlinkMatchers;
 import org.apache.flink.util.FileUtils;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.File;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.HamcrestCondition.matching;
 
 /** Tests for {@link JavaCodeSplitter}. */
-public class JavaCodeSplitterTest {
+class JavaCodeSplitterTest {
 
     @Test
-    public void testSplitJavaCode() {
+    void testSplitJavaCode() {
         runTest("TestSplitJavaCode", 100, 3);
     }
 
     @Test
-    public void testNotSplitJavaCode() {
+    void testNotSplitJavaCode() {
         runTest("TestNotSplitJavaCode", 4000, 10000);
     }
 
     @Test
-    public void testInvalidJavaCode() {
+    void testInvalidJavaCode() {
         try {
             JavaCodeSplitter.split("public class InvalidClass { return 1; }", 4000, 10000);

Review Comment:
   Yes, thanks.
   Agree. I noticed that the code throws nothing in case of syntax errors. I added this throwing.
   And another point: it looks the code does not check anything if the code length is less or equal than the specified max method length... Currently left it as it is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org