[jira] [Comment Edited] (OLINGO-283) Wrong OData Entities name from JPA

["Stephan Klevenz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OLINGO-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998528#comment-13998528 ] 

Stephan Klevenz edited comment on OLINGO-283 at 5/15/14 7:30 AM:
-----------------------------------------------------------------

This is an interesting and cool feature. However I have the following concerns which needs to be clarified first.

evo-inflect is another dependency which makes deployment for various application servers more complex. Actually this library is not OSGi enabled and won't work. I did look at source code which is two classes basically. The library is Apache 2.0 so an option would be to include the source code directly into the project. In this case we have to maintain the NOTICE file an point out the usage of the library [1]. We can support here.

Another issue is performance. While looking into the code it makes use of regex and we know from EdmSimpleType handling that regex could increase CPU usage and result in performance issues. I would appreciate to get some hard numbers to get a feeling how expensive such a call is actually. If you say a few milliseconds then this is maybe quite a lot. 

Last but not least we do not accept patches if they are without unit test. So for each change in code please provide a unit test case. You have also to ensure that the change does not break already existing tests.

And just for hint: patches can be easily created with git [2].

[1] http://www.apache.org/licenses/example-NOTICE.txt
[2] https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/


was (Author: klevenzs):
This is an interesting and cool feature. However I have the following concerns which needs to be clarified first.

evo-inflect is another dependency which makes deployment for various application servers more complex. Actually this library is not OSGi enabled and won't work. I did look at source code which is two classes basically. The library is Apache 2.0 so an option would be to include the source code directly into the project. In this case we have to maintain the NOTICE file an point out the usage of the library [1]. We can support here.

Another issue is performance. While looking into the code it makes use of regex and we know from EdmSimpleType handling that regex could increase CPU usage and result in performance issues. I would appreciate to get some hard numbers to get a feeling how expensive such a call is actually. If you say a few milliseconds then this is quite a lot. 

Last but not least we do not accept patches if they are without unit test. So for each change in code please provide a unit test case. You have also to ensure that the change does not break already existing tests.

And just for hint: patches can be easily created with git [2].

[1] http://www.apache.org/licenses/example-NOTICE.txt
[2] https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/

> Wrong OData Entities name from JPA
> ----------------------------------
>
>                 Key: OLINGO-283
>                 URL: https://issues.apache.org/jira/browse/OLINGO-283
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata2-jpa
>    Affects Versions: V2 1.3.0
>            Reporter: Felipe Taiarol
>            Assignee: Chandan V.A
>            Priority: Trivial
>              Labels: suggestion
>         Attachments: patch.zip
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When the OData entities are created from the JPA entities Olingo just adds an “s” at the end of the name. It would be nice if the correct plural was used instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)