You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/22 18:47:06 UTC

[GitHub] [spark] sujith71955 commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC interface

sujith71955 commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC interface
URL: https://github.com/apache/spark/pull/23899#discussion_r277391522
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/ColumnValue.java
 ##########
 @@ -193,7 +193,7 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
     case INTERVAL_DAY_TIME_TYPE:
       return stringValue((HiveIntervalDayTime) value);
     case DECIMAL_TYPE:
-      return stringValue(((HiveDecimal)value));
 
 Review comment:
    i will explore more based on your comment and update you guys.Thanks for your valuable suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org