[GitHub] [airflow] jedcunningham commented on a diff in pull request #31693: Replace unicodecsv with standard csv library

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #31693:
URL: https://github.com/apache/airflow/pull/31693#discussion_r1218377383


##########
airflow/providers/apache/hive/transfers/mysql_to_hive.py:
##########
@@ -84,7 +84,7 @@ def __init__(
         recreate: bool = False,
         partition: dict | None = None,
         delimiter: str = chr(1),
-        quoting: str | None = None,
+        quoting: int | None = None,

Review Comment:
   Is this a breaking change? If so, we should add something to the changelog.
   
   (same with the other one)



##########
tests/providers/microsoft/azure/transfers/test_oracle_to_azure_data_lake.py:
##########
@@ -69,8 +68,8 @@ def test_write_temp_file(self):
 
             assert os.path.exists(os.path.join(temp, filename)) == 1
 
-            with open(os.path.join(temp, filename), "rb") as csvfile:
-                temp_file = csv.reader(csvfile, delimiter=delimiter, encoding=encoding)

Review Comment:
   Should this encoding go into the open?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org