You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/21 22:03:32 UTC
[GitHub] [beam] bvolpato opened a new pull request, #22405: Improve exception when requested error tag does not exist (#22401)
bvolpato opened a new pull request, #22405:
URL: https://github.com/apache/beam/pull/22405
After 2.40.0 (more specifically, this PR https://github.com/apache/beam/pull/17423), there are three to get the failed inserts from a `BigQueryIO` Write, as it was now added a specific tag/PCollection when using the write method via Storage API (`STORAGE_WRITE_API` or `STORAGE_API_AT_LEAST_ONCE`).
The exception when the requested tag is null is misleading now, as it explicitly says that the other method should be used. However, in the case of Storage API, the recommended method won't work either.
Closes https://github.com/apache/beam/issues/22401
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] ~Update `CHANGES.md` with noteworthy changes~.
- [ ] ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)~.
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #22405: Improve exception when requested error tag does not exist (#22401)
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #22405:
URL: https://github.com/apache/beam/pull/22405#issuecomment-1191981611
R: @reuvenlax
Do you think the generic message "use a or b" is enough? Just to avoid giving a wrong recommendation.
I thought about explicitly checking what PCollection is available, but that may be too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #22405: Improve exception when requested error tag does not exist (#22401)
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on PR #22405:
URL: https://github.com/apache/beam/pull/22405#issuecomment-1205309379
Thanks for finding this and adding improved logs. This LGTM, please LMK if there is any reason to hold off on merging, otherwise I'll merge this in tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] bvolpato commented on pull request #22405: Improve exception when requested error tag does not exist (#22401)
Posted by GitBox <gi...@apache.org>.
bvolpato commented on PR #22405:
URL: https://github.com/apache/beam/pull/22405#issuecomment-1210101780
@johnjcasey Yes, this can be merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22405: Improve exception when requested error tag does not exist (#22401)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22405:
URL: https://github.com/apache/beam/pull/22405#issuecomment-1191985075
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey merged pull request #22405: Improve exception when requested error tag does not exist (#22401)
Posted by GitBox <gi...@apache.org>.
johnjcasey merged PR #22405:
URL: https://github.com/apache/beam/pull/22405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org