You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/01 07:26:03 UTC

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/
-----------------------------------------------------------

(Updated July 1, 2015, 5:26 a.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco Massenzio.


Changes
-------

rebased on top of Call protobuf changes. haven't addressed comments yet.


Bugs: MESOS-2551
    https://issues.apache.org/jira/browse/MESOS-2551


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
  src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 
  src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 

Diff: https://reviews.apache.org/r/35857/diff/


Testing
-------

make check

NOTE: Didn't add a new test because an existing test (SchedulerTest.TaskRunning) already exercises this code path.


Thanks,

Vinod Kone

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35857/
-----------------------------------------------------------

(Updated July 1, 2015, 10:18 p.m.)


Review request for mesos, Anand Mazumdar, Ben Mahler, Isabel Jimenez, and Marco Massenzio.


Changes
-------

rebased. NNFR.


Bugs: MESOS-2551
    https://issues.apache.org/jira/browse/MESOS-2551


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
  src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92 
  src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6 

Diff: https://reviews.apache.org/r/35857/diff/


Testing
-------

make check

NOTE: Didn't add a new test because an existing test (SchedulerTest.TaskRunning) already exercises this code path.


Thanks,

Vinod Kone