You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/08/30 14:15:24 UTC

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #638: MINIFICPP-1018 - Fix linking issues

phrocker commented on a change in pull request #638: MINIFICPP-1018 - Fix linking issues
URL: https://github.com/apache/nifi-minifi-cpp/pull/638#discussion_r319530810
 
 

 ##########
 File path: extensions/civetweb/CMakeLists.txt
 ##########
 @@ -33,6 +33,7 @@ set(BUILD_CIVET_TESTING OFF)
 add_subdirectory(${CIVET_THIRDPARTY_ROOT}
                  ${CIVET_BINARY_ROOT}
                  EXCLUDE_FROM_ALL)
+add_dependencies(c-library libressl-portable)
 
 Review comment:
   Is there no way to do this via the the main project? If not, can we create a document in the root that adds this caveat so that we at least have a documented path for continuing this? perhaps a new md tailed or, better yet,  to https://github.com/apache/nifi-minifi-cpp/blob/master/CONTRIB.md in a caveat section ( or something of the like )?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services