You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/15 00:12:44 UTC
Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits v1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15899
https://issues.apache.org/jira/browse/AMBARI-15899
Repository: ambari
Description
-------
Change the way to present the relation between global and individual alert check.
Other UX edits.
Diffs
-----
ambari-web/app/config.js 06afa49
ambari-web/app/controllers/global/cluster_controller.js 327bd45
ambari-web/app/controllers/global/update_controller.js e13fe41
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 1712b6f
ambari-web/app/controllers/main/alerts/definition_details_controller.js 8e716bc
ambari-web/app/messages.js 14c957c
ambari-web/app/styles/alerts.less 24b29b2
ambari-web/app/styles/application.less 61ccbfa
ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb
ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7
ambari-web/app/views/main/alerts/definition_details_view.js 606c955
ambari-web/test/controllers/global/update_controller_test.js 2c679c6
ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6
Diff: https://reviews.apache.org/r/46226/diff/
Testing
-------
Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits
v1
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/#review129014
-----------------------------------------------------------
ambari-web/app/controllers/main/alerts/definition_details_controller.js (line 301)
<https://reviews.apache.org/r/46226/#comment192478>
Hide tooltip instead of removing the dom.
- Richard Zang
On April 14, 2016, 10:12 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46226/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 10:12 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15899
> https://issues.apache.org/jira/browse/AMBARI-15899
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the way to present the relation between global and individual alert check.
> Other UX edits.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 06afa49
> ambari-web/app/controllers/global/cluster_controller.js 327bd45
> ambari-web/app/controllers/global/update_controller.js e13fe41
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 1712b6f
> ambari-web/app/controllers/main/alerts/definition_details_controller.js 8e716bc
> ambari-web/app/messages.js 14c957c
> ambari-web/app/styles/alerts.less 24b29b2
> ambari-web/app/styles/application.less 61ccbfa
> ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb
> ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7
> ambari-web/app/views/main/alerts/definition_details_view.js 606c955
> ambari-web/test/controllers/global/update_controller_test.js 2c679c6
> ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6
>
> Diff: https://reviews.apache.org/r/46226/diff/
>
>
> Testing
> -------
>
> Modified unit tests.
> Local ambari-web test passed.
> 25683 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits
v1
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/#review129109
-----------------------------------------------------------
Ship it!
ambari-web/app/messages.js (line 1013)
<https://reviews.apache.org/r/46226/#comment192584>
99 :) ... you'll never see any alerts
- Jonathan Hurley
On April 14, 2016, 8:14 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46226/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 8:14 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15899
> https://issues.apache.org/jira/browse/AMBARI-15899
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the way to present the relation between global and individual alert check.
> Other UX edits.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 06afa49
> ambari-web/app/controllers/global/cluster_controller.js 327bd45
> ambari-web/app/controllers/global/update_controller.js e13fe41
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 1712b6f
> ambari-web/app/controllers/main/alerts/definition_details_controller.js 8e716bc
> ambari-web/app/messages.js 14c957c
> ambari-web/app/styles/alerts.less 24b29b2
> ambari-web/app/styles/application.less 61ccbfa
> ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb
> ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7
> ambari-web/app/views/main/alerts/definition_details_view.js 606c955
> ambari-web/test/controllers/global/update_controller_test.js 2c679c6
> ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6
>
> Diff: https://reviews.apache.org/r/46226/diff/
>
>
> Testing
> -------
>
> Modified unit tests.
> Local ambari-web test passed.
> 25683 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits
v1
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/#review129046
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On April 15, 2016, 12:14 a.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46226/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 12:14 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15899
> https://issues.apache.org/jira/browse/AMBARI-15899
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the way to present the relation between global and individual alert check.
> Other UX edits.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 06afa49
> ambari-web/app/controllers/global/cluster_controller.js 327bd45
> ambari-web/app/controllers/global/update_controller.js e13fe41
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 1712b6f
> ambari-web/app/controllers/main/alerts/definition_details_controller.js 8e716bc
> ambari-web/app/messages.js 14c957c
> ambari-web/app/styles/alerts.less 24b29b2
> ambari-web/app/styles/application.less 61ccbfa
> ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb
> ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7
> ambari-web/app/views/main/alerts/definition_details_view.js 606c955
> ambari-web/test/controllers/global/update_controller_test.js 2c679c6
> ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6
>
> Diff: https://reviews.apache.org/r/46226/diff/
>
>
> Testing
> -------
>
> Modified unit tests.
> Local ambari-web test passed.
> 25683 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 46226: AMBARI-15899 Alert Check Retries: UX edits
v1
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46226/
-----------------------------------------------------------
(Updated April 15, 2016, 12:14 a.m.)
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Jonathan Hurley, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15899
https://issues.apache.org/jira/browse/AMBARI-15899
Repository: ambari
Description
-------
Change the way to present the relation between global and individual alert check.
Other UX edits.
Diffs (updated)
-----
ambari-web/app/config.js 06afa49
ambari-web/app/controllers/global/cluster_controller.js 327bd45
ambari-web/app/controllers/global/update_controller.js e13fe41
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 1712b6f
ambari-web/app/controllers/main/alerts/definition_details_controller.js 8e716bc
ambari-web/app/messages.js 14c957c
ambari-web/app/styles/alerts.less 24b29b2
ambari-web/app/styles/application.less 61ccbfa
ambari-web/app/templates/common/modal_popups/prompt_popup.hbs e1e03fb
ambari-web/app/templates/main/alerts/definition_details.hbs fab41c7
ambari-web/app/views/main/alerts/definition_details_view.js 606c955
ambari-web/test/controllers/global/update_controller_test.js 2c679c6
ambari-web/test/views/main/alerts/definition_details_view_test.js e6b88b6
Diff: https://reviews.apache.org/r/46226/diff/
Testing
-------
Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang