You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/28 08:47:13 UTC

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #625: Allow migration of detached volumes

rhtyd commented on a change in pull request #625:
URL: https://github.com/apache/cloudstack-primate/pull/625#discussion_r478957423



##########
File path: src/config/section/storage.js
##########
@@ -168,7 +168,7 @@ export default {
           label: 'label.migrate.volume',
           args: ['volumeid', 'storageid', 'livemigrate'],
           dataView: true,
-          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) && record.virtualmachineid },
+          show: (record, store) => { return record.state === 'Ready' && ['Admin'].includes(store.userInfo.roletype) },

Review comment:
       @Pearl1594 @davidjumani do we allow migration of attached VMs, for all hypervisors? What's the logic/check in old UI?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org