You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Steve Butler <st...@gmail.com> on 2015/11/10 21:14:51 UTC
Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree
implementations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40146/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 8:14 p.m.)
Review request for mesos and Alex Clemmer.
Changes
-------
Fixed up review comments and suggestions
Bugs: MESOS-3881
https://issues.apache.org/jira/browse/MESOS-3881
Repository: mesos
Description
-------
Windows: Unifies POSIX and Windows PSTree implementations
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 741639a942971e48e2dac42db238d423e61cac21
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp fd0192ca021eb0211b293eb2f4e521d588aff04f
3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 9baa2fbfafa310517b70d54f190167f1cccbad6a
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp f75a77fc58db09fadf80409f506852e48a7df7c4
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
Diff: https://reviews.apache.org/r/40146/diff/
Testing
-------
Thanks,
Steve Butler
Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree
implementations
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40146/#review105938
-----------------------------------------------------------
Bad patch!
Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559]
Failed command: ./support/apply-review.sh -n -r 39559
Error:
2015-11-10 20:16:27 URL:https://reviews.apache.org/r/39559/diff/raw/ [10306/10306] -> "39559.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:65
error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:83
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 10, 2015, 8:14 p.m., Steve Butler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40146/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 8:14 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Bugs: MESOS-3881
> https://issues.apache.org/jira/browse/MESOS-3881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Unifies POSIX and Windows PSTree implementations
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 741639a942971e48e2dac42db238d423e61cac21
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp fd0192ca021eb0211b293eb2f4e521d588aff04f
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 9baa2fbfafa310517b70d54f190167f1cccbad6a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp f75a77fc58db09fadf80409f506852e48a7df7c4
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/40146/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Butler
>
>
Re: Review Request 40146: Windows: Unifies POSIX and Windows PSTree
implementations
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40146/#review106936
-----------------------------------------------------------
Ship it!
Looks good. Just a few nits (newlines) here and there to stay consistent with the style guide.
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
<https://reviews.apache.org/r/40146/#comment165739>
We want to keep the double-space here.
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 278)
<https://reviews.apache.org/r/40146/#comment165741>
We want a double-space here.
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp
<https://reviews.apache.org/r/40146/#comment165740>
We want to keep the double-space here.
- Joseph Wu
On Nov. 10, 2015, 12:14 p.m., Steve Butler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40146/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 12:14 p.m.)
>
>
> Review request for mesos and Alex Clemmer.
>
>
> Bugs: MESOS-3881
> https://issues.apache.org/jira/browse/MESOS-3881
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Unifies POSIX and Windows PSTree implementations
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 741639a942971e48e2dac42db238d423e61cac21
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp fd0192ca021eb0211b293eb2f4e521d588aff04f
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 9baa2fbfafa310517b70d54f190167f1cccbad6a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp f75a77fc58db09fadf80409f506852e48a7df7c4
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 1a7037d64afeedc340258c92067e95d1d3caa027
>
> Diff: https://reviews.apache.org/r/40146/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Steve Butler
>
>