[GitHub] [incubator-hudi] nsivabalan edited a comment on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient

[GitBox <gi...@apache.org>]

nsivabalan edited a comment on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-555549907
 
 
   @bvaradar : Except for "Can you move the call addSchemaToConfig(metaClient) to delete() as it should only be called from there ?" comment, all other comments have been addressed for HoodieWriteClient fix. Feel free to review and virtually stamp for HoodieWriteClient fixes. 
   Once I am done with DataSource, will ping here. And you can review those changes. 
   
   Also, I haven't got response from you on these two questions for Datasource:
   
   1. I haven't made any checks for save mode in deletes. Can you advise me on what all save mode is applicable in delete and whats expected behavior. I thought some may not be applicable to deletes and hence wanted your opinions.
   FYI: Here are the save mode in write path.
   
   ErrorIfExists : will throw error if dataset exists
   Ignore: If dataset already exists, do not make any write and return silently.
   Overwrite: if data set exists, delete and overwrite.
   
   2. I haven't done anything for dropping duplicates in delete path. Is it required?
   I am talking something similar to "hoodie.datasource.write.insert.drop.duplicates" for deletes
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services