You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/05 04:15:24 UTC
Review Request 14510: Added authentication tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-704
https://issues.apache.org/jira/browse/MESOS-704
Repository: mesos-git
Description
-------
New tests added to specifically to test authentication.
Diffs
-----
src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
src/tests/authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14510/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14510: Added authentication tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/#review26855
-----------------------------------------------------------
Ship it!
src/tests/authentication_tests.cpp
<https://reviews.apache.org/r/14510/#comment52232>
s/.././
src/tests/authentication_tests.cpp
<https://reviews.apache.org/r/14510/#comment52233>
s/.././
src/tests/authentication_tests.cpp
<https://reviews.apache.org/r/14510/#comment52234>
What about adding another expectation to see another AuthenticateMessage? I.e., that we retried even though the master thought this framework was authenticated? In fact, getting another AuthenticationCompletedMessage would also imply that the master went through the authentication process again.
- Benjamin Hindman
On Oct. 8, 2013, 11:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14510/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-704
> https://issues.apache.org/jira/browse/MESOS-704
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> New tests added to specifically to test authentication.
>
>
> Diffs
> -----
>
> src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
> src/tests/authentication_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14510/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14510: Added authentication tests.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/#review26758
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/14510/#comment52079>
I love the cleanup but can we start the list on a new line and only indent by 2? See other examples in this file that have been reformatted as well.
- Benjamin Hindman
On Oct. 8, 2013, 11:28 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14510/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 11:28 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-704
> https://issues.apache.org/jira/browse/MESOS-704
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> New tests added to specifically to test authentication.
>
>
> Diffs
> -----
>
> src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
> src/tests/authentication_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14510/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 14510: Added authentication tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/
-----------------------------------------------------------
(Updated Oct. 10, 2013, 10:26 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's. NNFR.
Bugs: MESOS-704
https://issues.apache.org/jira/browse/MESOS-704
Repository: mesos-git
Description
-------
New tests added to specifically to test authentication.
Diffs (updated)
-----
src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
src/tests/authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14510/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14510: Added authentication tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/
-----------------------------------------------------------
(Updated Oct. 8, 2013, 11:28 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
rebased.
Bugs: MESOS-704
https://issues.apache.org/jira/browse/MESOS-704
Repository: mesos-git
Description
-------
New tests added to specifically to test authentication.
Diffs (updated)
-----
src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
src/tests/authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14510/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 14510: Added authentication tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14510/
-----------------------------------------------------------
(Updated Oct. 7, 2013, 8:04 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added more tests.
Bugs: MESOS-704
https://issues.apache.org/jira/browse/MESOS-704
Repository: mesos-git
Description
-------
New tests added to specifically to test authentication.
Diffs (updated)
-----
src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147
src/tests/authentication_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/14510/diff/
Testing
-------
make check
Thanks,
Vinod Kone