You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 05:14:30 UTC
[GitHub] [spark] c21 opened a new pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
c21 opened a new pull request #31641:
URL: https://github.com/apache/spark/pull/31641
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
I discovered from review discussion - https://github.com/apache/spark/pull/31630#discussion_r581774000 , that we can eliminate LEFT ANTI join (with no join condition) to empty relation, if the right side is known to be non-empty. So with AQE, this is doable similar to https://github.com/apache/spark/pull/29484 .
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This can help eliminate the join operator during logical plan optimization.
Before this PR, [left side physical plan `execute()` will be called](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala#L192), so if left side is complicated (e.g. contain broadcast exchange operator), then some computation would happen. However after this PR, the join operator will be removed during logical plan, and nothing will be computed from left side. Potentially it can save resource for these kinds of query.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit tests for positive and negative queries in `AdaptiveQueryExecSuite.scala`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785700557
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786525901
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135489/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785661989
**[Test build #135457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135457/testReport)** for PR 31641 at commit [`255ee07`](https://github.com/apache/spark/commit/255ee0754ffb35586135d12d87949a745fb1f082).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785681020
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786323819
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40061/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785669298
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40034/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786272287
**[Test build #135479 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135479/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785632841
**[Test build #135454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135454/testReport)** for PR 31641 at commit [`ead65c8`](https://github.com/apache/spark/commit/ead65c80461d65ce9fad4d091c0da92a060a0972).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785660196
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40036/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786421446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786282656
**[Test build #135481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135481/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785661989
**[Test build #135457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135457/testReport)** for PR 31641 at commit [`255ee07`](https://github.com/apache/spark/commit/255ee0754ffb35586135d12d87949a745fb1f082).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786246289
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785681019
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785633849
**[Test build #135456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135456/testReport)** for PR 31641 at commit [`e9e7b16`](https://github.com/apache/spark/commit/e9e7b160aa5b892c47c4131fefe67744fec6352f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785647386
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40036/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785714298
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786598592
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786273853
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786525901
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135489/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786612177
Thanks for the update, @c21 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786192546
**[Test build #135479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135479/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786385853
**[Test build #135481 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135481/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785649477
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786323819
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40061/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r583367657
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1230,6 +1237,30 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-34533: Eliminate left anti join to empty relation") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
+ withTable("emptyTestData") {
+ spark.range(0).write.saveAsTable("emptyTestData")
+ Seq(
+ // broadcast non-empty right side
+ ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN testData3", true),
+ // broadcast empty right side
+ ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI JOIN emptyTestData",
+ false),
+ // broadcast left side
+ ("SELECT /*+ broadcast(testData) */ * FROM testData LEFT ANTI JOIN testData3", false)
+ ).foreach { case (query, isEliminated) =>
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
+ val bnlj = findTopLevelBroadcastNestedLoopJoin(plan)
Review comment:
@cloud-fan - agree, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786419889
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r583355683
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1230,6 +1237,30 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-34533: Eliminate left anti join to empty relation") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
+ withTable("emptyTestData") {
+ spark.range(0).write.saveAsTable("emptyTestData")
+ Seq(
+ // broadcast non-empty right side
+ ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN testData3", true),
+ // broadcast empty right side
+ ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI JOIN emptyTestData",
+ false),
+ // broadcast left side
+ ("SELECT /*+ broadcast(testData) */ * FROM testData LEFT ANTI JOIN testData3", false)
+ ).foreach { case (query, isEliminated) =>
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
+ val bnlj = findTopLevelBroadcastNestedLoopJoin(plan)
Review comment:
Do we need to create `findTopLevelBroadcastNestedLoopJoin`? We just want to prove that, the non-AQE plan has join and the AQE one has no join. `findTopLevelBaseJoin` should be good enough here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786421446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785631884
**[Test build #135454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135454/testReport)** for PR 31641 at commit [`ead65c8`](https://github.com/apache/spark/commit/ead65c80461d65ce9fad4d091c0da92a060a0972).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785649482
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786785293
Thank you @cloud-fan and @maropu for review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785633849
**[Test build #135456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135456/testReport)** for PR 31641 at commit [`e9e7b16`](https://github.com/apache/spark/commit/e9e7b160aa5b892c47c4131fefe67744fec6352f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785826184
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135457/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785651917
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40034/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786192546
**[Test build #135479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135479/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786386588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135481/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r583118271
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateJoinToEmptyRelation.scala
##########
@@ -53,5 +57,23 @@ object EliminateJoinToEmptyRelation extends Rule[LogicalPlan] {
case j @ Join(_, _, LeftSemi, _, _) if canEliminate(j.right, EmptyHashedRelation) =>
LocalRelation(j.output, data = Seq.empty, isStreaming = j.isStreaming)
+
+ case j @ Join(_, _, LeftAnti, None, _) =>
+ val isNonEmptyBroadcastedRightSide = j.right match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
Review comment:
@cloud-fan - thanks, use row count is better, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786306803
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40061/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785631884
**[Test build #135454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135454/testReport)** for PR 31641 at commit [`ead65c8`](https://github.com/apache/spark/commit/ead65c80461d65ce9fad4d091c0da92a060a0972).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r582775569
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateJoinToEmptyRelation.scala
##########
@@ -33,6 +34,9 @@ import org.apache.spark.sql.execution.joins.{EmptyHashedRelation, HashedRelation
* This applies to all Joins (sort merge join, shuffled hash join, and broadcast hash join),
* because sort merge join and shuffled hash join will be changed to broadcast hash join with AQE
* at the first place.
+ *
+ * 3. Join is left anti join without condition, and broadcasted join right side is not empty.
+ * This applies to broadcast nested loop join only.
Review comment:
Why do we care about the physical plan? I think it's a logical optimization that left anti join without condition can be turned into empty relation if right side is non-empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r582774822
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateJoinToEmptyRelation.scala
##########
@@ -53,5 +57,23 @@ object EliminateJoinToEmptyRelation extends Rule[LogicalPlan] {
case j @ Join(_, _, LeftSemi, _, _) if canEliminate(j.right, EmptyHashedRelation) =>
LocalRelation(j.output, data = Seq.empty, isStreaming = j.isStreaming)
+
+ case j @ Join(_, _, LeftAnti, None, _) =>
+ val isNonEmptyBroadcastedRightSide = j.right match {
+ case LogicalQueryStage(_, stage: BroadcastQueryStageExec)
Review comment:
nit:
```
case LogicalQueryStage(_, stage: QueryStageExec) =>
stage.getRuntimeStatistics.rowCount.exists(_ > 0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786386588
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135481/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786282656
**[Test build #135481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135481/testReport)** for PR 31641 at commit [`8e5f35d`](https://github.com/apache/spark/commit/8e5f35d559c0c5fe33fdd29dfd2d5106dad1dd16).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31641:
URL: https://github.com/apache/spark/pull/31641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786204684
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786410309
**[Test build #135489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135489/testReport)** for PR 31641 at commit [`934306e`](https://github.com/apache/spark/commit/934306e16d961a6d8373252082e0f0417181b7f4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786272444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135479/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786517144
**[Test build #135489 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135489/testReport)** for PR 31641 at commit [`934306e`](https://github.com/apache/spark/commit/934306e16d961a6d8373252082e0f0417181b7f4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785714298
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785634919
**[Test build #135456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135456/testReport)** for PR 31641 at commit [`e9e7b16`](https://github.com/apache/spark/commit/e9e7b160aa5b892c47c4131fefe67744fec6352f).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786318976
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40061/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786410309
**[Test build #135489 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135489/testReport)** for PR 31641 at commit [`934306e`](https://github.com/apache/spark/commit/934306e16d961a6d8373252082e0f0417181b7f4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786418306
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786271492
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785617988
cc @cloud-fan and @maropu to take a look if you have time, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785826184
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135457/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] c21 commented on a change in pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
c21 commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r583119600
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateJoinToEmptyRelation.scala
##########
@@ -33,6 +34,9 @@ import org.apache.spark.sql.execution.joins.{EmptyHashedRelation, HashedRelation
* This applies to all Joins (sort merge join, shuffled hash join, and broadcast hash join),
* because sort merge join and shuffled hash join will be changed to broadcast hash join with AQE
* at the first place.
+ *
+ * 3. Join is left anti join without condition, and broadcasted join right side is not empty.
+ * This applies to broadcast nested loop join only.
Review comment:
@cloud-fan - I agree. Updated to remove this restriction. I was not thinking towards to use row count stats at the first place, so was checking the size of `Array[InternalRow]` for `BroadcastNestedLoopJoinExec`, so was having this restriction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785684817
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-785820302
**[Test build #135457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135457/testReport)** for PR 31641 at commit [`255ee07`](https://github.com/apache/spark/commit/255ee0754ffb35586135d12d87949a745fb1f082).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786272444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135479/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31641: [SPARK-34533][SQL] Eliminate LEFT ANTI join to empty relation in AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31641:
URL: https://github.com/apache/spark/pull/31641#issuecomment-786271492
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40059/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org