You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/25 08:11:37 UTC
[GitHub] [pulsar] mattisonchao opened a new pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
mattisonchao opened a new pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501
### Motivation
It's ``AddtionalServelt`` side change, like #11270
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
Change context class loader through Thread.currentThread().setContextClassLoader(classLoader) before every protocol handler callback, and change it back to original class loader afterwards.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API: ( no)
- The schema: ( no)
- The default values of configurations: ( no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower merged pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
BewareMyPower merged pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1002396706
@BewareMyPower I will do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1002375137
Could you add a test to verify this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1001007892
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1002923160
@BewareMyPower
I have added test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao removed a comment on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
mattisonchao removed a comment on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1002945042
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #13501: Change ContextClassLoader to NarClassLoader in AdditionalServlet
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on pull request #13501:
URL: https://github.com/apache/pulsar/pull/13501#issuecomment-1002945042
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org