You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@marvin.apache.org by GitBox <gi...@apache.org> on 2019/09/09 14:12:17 UTC

[GitHub] [incubator-marvin] oldfly commented on a change in pull request #32: BaseURL Configuration for MarvinAI Notebook

oldfly commented on a change in pull request #32: BaseURL Configuration for MarvinAI Notebook
URL: https://github.com/apache/incubator-marvin/pull/32#discussion_r322261638
 
 

 ##########
 File path: python-toolbox/marvin_python_toolbox/management/notebook.py
 ##########
 @@ -29,15 +29,15 @@ def cli():
 
 @cli.command('notebook', help='Start the Jupyter notebook server.')
 @click.option('--port', '-p', default=8888, help='Jupyter server port')
+@click.option('--base-url', '-p', default='/', help='Jupyter server base url')
 
 Review comment:
   The short parameter for base url could be something else than '-p' that conflicts with Port´s short parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services