You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangyongtian (via GitHub)" <gi...@apache.org> on 2023/04/25 02:27:26 UTC

[GitHub] [doris] zhangyongtian opened a new pull request, #19024: [Fix] Fix the extension mysql_to_doris bug (#18993)

zhangyongtian opened a new pull request, #19024:
URL: https://github.com/apache/doris/pull/19024

   extension mysql_to_doris: Expected: ADMIN is keyword, maybe `ADMIN`
   
   # Proposed changes
   
   Issue Number: close #18993
   
   ## Problem summary
   
   1. The table names generated by the original code are as follows. If there is a keyword table like admin above, an error will be reported.
       ![4ef5ea5825a1e66c78232bed011e9b0](https://user-images.githubusercontent.com/63942121/234159443-63249700-94fe-4804-bcf5-90fd9a707f3d.png)
   2. The modified effect is as follows.
       ![29f0a64edb65f182f83fe0820aec7fd](https://user-images.githubusercontent.com/63942121/234159477-96270572-7cb2-43d5-a2d7-3cc226438115.png)
   
   
   ## Checklist(Required)
   
   * [x] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix] Fix the extension mysql_to_doris bug (#18993) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19024:
URL: https://github.com/apache/doris/pull/19024#issuecomment-1774240789

   We're closing this PR because it hasn't been updated in a while.
   This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix] Fix the extension mysql_to_doris bug (#18993) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #19024: [Fix] Fix the extension mysql_to_doris bug (#18993)
URL: https://github.com/apache/doris/pull/19024


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org