You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Wade Simmons (Commented) (JIRA)" <ji...@apache.org> on 2012/01/20 23:30:40 UTC

[jira] [Commented] (THRIFT-1353) Switch to performance branch, get rid of BinaryParser

    [ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190177#comment-13190177 ] 

Wade Simmons commented on THRIFT-1353:
--------------------------------------

All of the feedback I've heard is positive. Can we get this merged in?
                
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
>                 Key: THRIFT-1353
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1353
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.7
>            Reporter: Hans Duedal
>              Labels: node, nodejs
>             Fix For: 0.9
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira